Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Script Cleaning and Fixes #114

Merged
merged 7 commits into from
Sep 6, 2024
Merged

Script Cleaning and Fixes #114

merged 7 commits into from
Sep 6, 2024

Conversation

kevinthedang
Copy link
Owner

Changes

  • Nodemon is no longer apart of scripts due to node version incompatibilities.
  • Scripts are organized a bit better.
  • Certain start/clean scripts have been fixed to actually do what they are supposed to do.
    • Start: Build discord image, build network to communicate, start both containers with correct IPs
    • Clean: Stop containers and clean them up and the images, prune networks, remove any dangling images.
  • Readme changes

@kevinthedang kevinthedang added documentation Improvements or additions to documentation technical Non-business related labels Sep 6, 2024
@kevinthedang kevinthedang self-assigned this Sep 6, 2024
@kevinthedang kevinthedang linked an issue Sep 6, 2024 that may be closed by this pull request
Reduce/Cleanup Script Clutter #87
Closed
@kevinthedang
Copy link
Owner Author

Will mention #112 as we are modifying the readme.

JT2M0L3Y
JT2M0L3Y approved these changes Sep 6, 2024
View reviewed changes
Copy link
Collaborator

@JT2M0L3Y JT2M0L3Y left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better.
Everything looks to work, good catch to use kevinthedang on the "clean" command and awesome application of tr and cut in the "docker:clean" command.
It's also good that we finally pushed out the mention of a version in the docker-compose, just one less annoying warning received when building the image!

@JT2M0L3Y JT2M0L3Y merged commit b49b464 into master Sep 6, 2024
1 check passed
@JT2M0L3Y JT2M0L3Y deleted the scripts-declutter branch September 6, 2024 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JT2M0L3Y JT2M0L3Y JT2M0L3Y approved these changes

Assignees

@kevinthedang kevinthedang

Labels
documentation Improvements or additions to documentation technical Non-business related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reduce/Cleanup Script Clutter
2 participants
@kevinthedang @JT2M0L3Y