-
Notifications
You must be signed in to change notification settings - Fork 7.7k
[KEYCLOAK-4523] New Password Hash Providers #3981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Derived key sizes at least 10x length of hash output.
* Shortened IDs for new pbkdf2 providers * Updated default PasswordPolicy to use pbkdf2-sha256 * Add unit test for hash algorithm configuration.
Thanks for your PR and sorry it has taken so long to review this. I'm closing this PR as I've done some refactoring of it. Mainly due to the fact that we want to backport this to RH-SSO 7.1 where we only want to add the new providers, but not change the defaults. I've opened a new PR with just the providers (#4128). I will follow-up with PR to change the default in master shortly. Thanks again :) |
This was referenced Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PasswordPolicy
andRealmManager
defaults to use SHA-256 and 28,000 iterations