Skip to content

Run Base UT even on Windows platform #42797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Run Base UT even on Windows platform #42797

wants to merge 2 commits into from

Conversation

Pepo48
Copy link
Contributor

@Pepo48 Pepo48 commented Sep 21, 2025

Closes: #42796

@Pepo48 Pepo48 requested a review from a team as a code owner September 21, 2025 13:03
stianst
stianst requested changes Sep 25, 2025
View reviewed changes
Copy link
Contributor

@stianst stianst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather run these as part of JDK tests;
#33510

@Pepo48
Run Base UT even on Windows platform
d0d0e97 
Closes: keycloak#42796

Signed-off-by: Peter Zaoral <pepo48@gmail.com>
@Pepo48
Integrate unit test execution into the Base Integration Tests job
70091f9 
Signed-off-by: Peter Zaoral <pepo48@gmail.com>
keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Sep 26, 2025
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.oauth.ClientAuthSignedJWTTest#testClientWithGeneratedKeysJKS

Keycloak CI - Base IT (6)

java.lang.AssertionError: 

Expected: (a value greater than <1853585441358L> and a value less than <1853585451358L>)
     but: a value greater than <1853585441358L> <1853585440000L> was less than <1853585441358L>
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
...

Report flaky test

@Pepo48 Pepo48 marked this pull request as draft September 26, 2025 16:02
@stianst
Copy link
Contributor

stianst commented Oct 7, 2025

Closing this in favour of #43240

@stianst stianst closed this Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stianst stianst stianst requested changes

+1 more reviewer

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
flaky-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI] Running Base UT on Windows
2 participants
@Pepo48 @stianst