Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the last decoder allocation #142

Merged
merged 4 commits into from
Jul 28, 2019
Merged

Remove the last decoder allocation #142

merged 4 commits into from
Jul 28, 2019

Conversation

klauspost
Copy link
Owner 

benchmark                                            old ns/op     new ns/op     delta
BenchmarkDecoder_DecodeAll/kppkn.gtb.zst-12          608499        610005        +0.25%
BenchmarkDecoder_DecodeAll/geo.protodata.zst-12      136501        137699        +0.88%
BenchmarkDecoder_DecodeAll/plrabn12.txt.zst-12       1967989       1944000       -1.22%
BenchmarkDecoder_DecodeAll/lcet10.txt.zst-12         1448010       1444000       -0.28%
BenchmarkDecoder_DecodeAll/asyoulik.txt.zst-12       504333        504333        +0.00%
BenchmarkDecoder_DecodeAll/alice29.txt.zst-12        650494        652504        +0.31%
BenchmarkDecoder_DecodeAll/html_x_4.zst-12           267000        267199        +0.07%
BenchmarkDecoder_DecodeAll/paper-100k.pdf.zst-12     24840         24659         -0.73%
BenchmarkDecoder_DecodeAll/fireworks.jpeg.zst-12     9594          9639          +0.47%
BenchmarkDecoder_DecodeAll/urls.10K.zst-12           1662010       1670000       +0.48%
BenchmarkDecoder_DecodeAll/html.zst-12               156400        155601        -0.51%

benchmark                                            old MB/s     new MB/s     speedup
BenchmarkDecoder_DecodeAll/kppkn.gtb.zst-12          302.91       302.16       1.00x
BenchmarkDecoder_DecodeAll/geo.protodata.zst-12      868.77       861.21       0.99x
BenchmarkDecoder_DecodeAll/plrabn12.txt.zst-12       244.85       247.87       1.01x
BenchmarkDecoder_DecodeAll/lcet10.txt.zst-12         294.72       295.54       1.00x
BenchmarkDecoder_DecodeAll/asyoulik.txt.zst-12       248.21       248.21       1.00x
BenchmarkDecoder_DecodeAll/alice29.txt.zst-12        233.81       233.09       1.00x
BenchmarkDecoder_DecodeAll/html_x_4.zst-12           1534.08      1532.93      1.00x
BenchmarkDecoder_DecodeAll/paper-100k.pdf.zst-12     4122.35      4152.47      1.01x
BenchmarkDecoder_DecodeAll/fireworks.jpeg.zst-12     12828.87     12769.05     1.00x
BenchmarkDecoder_DecodeAll/urls.10K.zst-12           422.43       420.41       1.00x
BenchmarkDecoder_DecodeAll/html.zst-12               654.73       658.09       1.01x

benchmark                                            old allocs     new allocs     delta
BenchmarkDecoder_DecodeAll/kppkn.gtb.zst-12          1              0              -100.00%
BenchmarkDecoder_DecodeAll/geo.protodata.zst-12      1              0              -100.00%
BenchmarkDecoder_DecodeAll/plrabn12.txt.zst-12       1              0              -100.00%
BenchmarkDecoder_DecodeAll/lcet10.txt.zst-12         1              0              -100.00%
BenchmarkDecoder_DecodeAll/asyoulik.txt.zst-12       1              0              -100.00%
BenchmarkDecoder_DecodeAll/alice29.txt.zst-12        1              0              -100.00%
BenchmarkDecoder_DecodeAll/html_x_4.zst-12           1              0              -100.00%
BenchmarkDecoder_DecodeAll/paper-100k.pdf.zst-12     1              0              -100.00%
BenchmarkDecoder_DecodeAll/fireworks.jpeg.zst-12     1              0              -100.00%
BenchmarkDecoder_DecodeAll/urls.10K.zst-12           1              0              -100.00%
BenchmarkDecoder_DecodeAll/html.zst-12               1              0              -100.00%

benchmark                                            old bytes     new bytes     delta
BenchmarkDecoder_DecodeAll/kppkn.gtb.zst-12          32            0             -100.00%
BenchmarkDecoder_DecodeAll/geo.protodata.zst-12      32            0             -100.00%
BenchmarkDecoder_DecodeAll/plrabn12.txt.zst-12       32            0             -100.00%
BenchmarkDecoder_DecodeAll/lcet10.txt.zst-12         32            0             -100.00%
BenchmarkDecoder_DecodeAll/asyoulik.txt.zst-12       32            0             -100.00%
BenchmarkDecoder_DecodeAll/alice29.txt.zst-12        32            0             -100.00%
BenchmarkDecoder_DecodeAll/html_x_4.zst-12           32            0             -100.00%
BenchmarkDecoder_DecodeAll/paper-100k.pdf.zst-12     32            0             -100.00%
BenchmarkDecoder_DecodeAll/fireworks.jpeg.zst-12     32            0             -100.00%
BenchmarkDecoder_DecodeAll/urls.10K.zst-12           32            0             -100.00%
BenchmarkDecoder_DecodeAll/html.zst-12               32            0             -100.00%

@klauspost
Remove the last decoder allocation
9bccfa5 
```
benchmark                                            old ns/op     new ns/op     delta
BenchmarkDecoder_DecodeAll/kppkn.gtb.zst-12          608499        610005        +0.25%
BenchmarkDecoder_DecodeAll/geo.protodata.zst-12      136501        137699        +0.88%
BenchmarkDecoder_DecodeAll/plrabn12.txt.zst-12       1967989       1944000       -1.22%
BenchmarkDecoder_DecodeAll/lcet10.txt.zst-12         1448010       1444000       -0.28%
BenchmarkDecoder_DecodeAll/asyoulik.txt.zst-12       504333        504333        +0.00%
BenchmarkDecoder_DecodeAll/alice29.txt.zst-12        650494        652504        +0.31%
BenchmarkDecoder_DecodeAll/html_x_4.zst-12           267000        267199        +0.07%
BenchmarkDecoder_DecodeAll/paper-100k.pdf.zst-12     24840         24659         -0.73%
BenchmarkDecoder_DecodeAll/fireworks.jpeg.zst-12     9594          9639          +0.47%
BenchmarkDecoder_DecodeAll/urls.10K.zst-12           1662010       1670000       +0.48%
BenchmarkDecoder_DecodeAll/html.zst-12               156400        155601        -0.51%

benchmark                                            old MB/s     new MB/s     speedup
BenchmarkDecoder_DecodeAll/kppkn.gtb.zst-12          302.91       302.16       1.00x
BenchmarkDecoder_DecodeAll/geo.protodata.zst-12      868.77       861.21       0.99x
BenchmarkDecoder_DecodeAll/plrabn12.txt.zst-12       244.85       247.87       1.01x
BenchmarkDecoder_DecodeAll/lcet10.txt.zst-12         294.72       295.54       1.00x
BenchmarkDecoder_DecodeAll/asyoulik.txt.zst-12       248.21       248.21       1.00x
BenchmarkDecoder_DecodeAll/alice29.txt.zst-12        233.81       233.09       1.00x
BenchmarkDecoder_DecodeAll/html_x_4.zst-12           1534.08      1532.93      1.00x
BenchmarkDecoder_DecodeAll/paper-100k.pdf.zst-12     4122.35      4152.47      1.01x
BenchmarkDecoder_DecodeAll/fireworks.jpeg.zst-12     12828.87     12769.05     1.00x
BenchmarkDecoder_DecodeAll/urls.10K.zst-12           422.43       420.41       1.00x
BenchmarkDecoder_DecodeAll/html.zst-12               654.73       658.09       1.01x

benchmark                                            old allocs     new allocs     delta
BenchmarkDecoder_DecodeAll/kppkn.gtb.zst-12          1              0              -100.00%
BenchmarkDecoder_DecodeAll/geo.protodata.zst-12      1              0              -100.00%
BenchmarkDecoder_DecodeAll/plrabn12.txt.zst-12       1              0              -100.00%
BenchmarkDecoder_DecodeAll/lcet10.txt.zst-12         1              0              -100.00%
BenchmarkDecoder_DecodeAll/asyoulik.txt.zst-12       1              0              -100.00%
BenchmarkDecoder_DecodeAll/alice29.txt.zst-12        1              0              -100.00%
BenchmarkDecoder_DecodeAll/html_x_4.zst-12           1              0              -100.00%
BenchmarkDecoder_DecodeAll/paper-100k.pdf.zst-12     1              0              -100.00%
BenchmarkDecoder_DecodeAll/fireworks.jpeg.zst-12     1              0              -100.00%
BenchmarkDecoder_DecodeAll/urls.10K.zst-12           1              0              -100.00%
BenchmarkDecoder_DecodeAll/html.zst-12               1              0              -100.00%

benchmark                                            old bytes     new bytes     delta
BenchmarkDecoder_DecodeAll/kppkn.gtb.zst-12          32            0             -100.00%
BenchmarkDecoder_DecodeAll/geo.protodata.zst-12      32            0             -100.00%
BenchmarkDecoder_DecodeAll/plrabn12.txt.zst-12       32            0             -100.00%
BenchmarkDecoder_DecodeAll/lcet10.txt.zst-12         32            0             -100.00%
BenchmarkDecoder_DecodeAll/asyoulik.txt.zst-12       32            0             -100.00%
BenchmarkDecoder_DecodeAll/alice29.txt.zst-12        32            0             -100.00%
BenchmarkDecoder_DecodeAll/html_x_4.zst-12           32            0             -100.00%
BenchmarkDecoder_DecodeAll/paper-100k.pdf.zst-12     32            0             -100.00%
BenchmarkDecoder_DecodeAll/fireworks.jpeg.zst-12     32            0             -100.00%
BenchmarkDecoder_DecodeAll/urls.10K.zst-12           32            0             -100.00%
BenchmarkDecoder_DecodeAll/html.zst-12               32            0             -100.00%
```
@klauspost klauspost mentioned this pull request Jul 28, 2019
Closed
valyala
valyala reviewed Jul 28, 2019
View reviewed changes
zstd/framedec.go Outdated Show resolved Hide resolved
zstd/decoder.go Outdated Show resolved Hide resolved
valyala
valyala reviewed Jul 28, 2019
View reviewed changes
zstd/decoder.go Outdated Show resolved Hide resolved
@klauspost
Copy link
Owner Author

@valyala Good suggestions. PTAL.

valyala
valyala approved these changes Jul 28, 2019
View reviewed changes
Copy link

@valyala valyala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@klauspost klauspost merged commit c7c6a27 into master Jul 28, 2019
@klauspost klauspost deleted the remove-decoder-alloc branch July 28, 2019 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valyala valyala valyala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klauspost @valyala