-
Notifications
You must be signed in to change notification settings - Fork 6
✨ Add PositiveInteger
experimental type
#856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f1772f8
to
3be6458
Compare
Includes now the string serializer of the `PositiveInteger` type.
We will not introduce the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This request introduces the
PositiveInteger
experimental type, in theorg.kotools.types
package from thetypes
module, for representing an integer that is greater than zero.Contrarily to the integer types provided by Kotlin (
Byte
,Short
,Int
andLong
), this type has no maximum value and can hold greater values thanLong.MAX_VALUE
.The
PositiveInteger
type is available on all platforms supported by Kotools Types.Instance creation
This request adds the
PositiveInteger.Companion.of
function for creating an instance of thePositiveInteger
type fromString
.✅ Checklist
PositiveInteger
type as value class with private constructor and documentation.PositiveInteger.of(String)
function with tests, documentation and samples.PositiveInteger.toString()
function with documentation, samples and tests.PositiveInteger.of(Int)
function with tests, documentation and samples.PositiveInteger.of(Long)
function with tests, documentation and samples.PositiveInteger
type serializable asString
.➡️ What's coming next
PositiveIntegerFormat
type and thePositiveInteger.toString(PositiveIntegerFormat.() -> Unit)
extension function, for returning the formatted string representation of this positive integer. ThePositiveIntegerFormat.thousandsSeparator()
function must follow the ISO 31-0 standard by using the space character (PositiveInteger
type comparable withPositiveInteger
,Int
andLong
types.