feat: Supports filter string using regular expression matching #3055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chai3 is attempting to deploy a commit to the langfuse Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Disclaimer: Experimental PR review
PR Summary
This PR adds support for regular expression matching in filters, enhancing string matching capabilities in the Langfuse system.
- Added 'regex with' operator in
packages/shared/src/filterToPrisma.ts, mapping to PostgreSQL's case-insensitive regex operator '~*' - Updated
packages/shared/src/interfaces/filters.tsto include 'regex with' operator for 'string' and 'stringObject' filter types - Implementation follows existing patterns for filter operations, but requires careful consideration of security and performance implications
- No changes made to existing regex validation functions, which should be utilized to ensure safe regex usage
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
|
invalid regex got can this be allowed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
closes #XXX(not yet issues)
https://github.com/orgs/langfuse/discussions/3014
Type of change