Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: disable fs instrumentation #3372

Closed
wants to merge 1 commit into from
Closed

perf: disable fs instrumentation #3372

wants to merge 1 commit into from

Conversation

maxdeichmann
Copy link
Member

What does this PR do?

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (does not change functionality, e.g. code style improvements, linting)
  • This change requires a documentation update

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project (npm run prettier)
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings (npm run lint)
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@vercel Vercel
Copy link

vercel bot commented Sep 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
langfuse-cloud ✅ Ready (Inspect) Visit Preview Sep 16, 2024 7:52pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
langfuse-cloud-us ⬜️ Ignored (Inspect) Sep 16, 2024 7:52pm

@maxdeichmann maxdeichmann changed the title perf perf: disable fs instrumentation Sep 16, 2024
greptile-apps[bot]
greptile-apps bot reviewed Sep 16, 2024
View reviewed changes
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disclaimer: Experimental PR review

PR Summary

This PR disables file system instrumentation in OpenTelemetry auto-instrumentations for Node.js, likely to improve performance by reducing tracing overhead.

  • Modified web/src/datadog.server.config.ts to disable @opentelemetry/instrumentation-fs
  • Potential performance improvement by reducing tracing of file system operations
  • May impact observability of file system activities in tracing data
  • Low-risk change with minimal code modification
  • Consider monitoring system performance and tracing data quality after implementation

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@Steffen911 Steffen911 deleted the disable-fs-instrumentation branch October 8, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@maxdeichmann