Skip to content

Use default executor constructor where possible #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 11, 2024
Merged

Use default executor constructor where possible #284

merged 4 commits into from
Mar 11, 2024

Conversation

@Masynchin
Copy link
Contributor

@Masynchin Masynchin commented Mar 8, 2024 •
edited
Loading

In tests where ref not used (which is half of all tests) I have replaced it with createExecutor() where executor parameters set to defaults, and createExecutor(n) where n is not equals to default 300

@Masynchin Masynchin marked this pull request as draft March 8, 2024 15:32
@Masynchin
Copy link
Contributor Author

I will tweak this PR after #281 will be merged

@lenguyenthanh
Copy link
Member

thanks @Masynchin, f.y.i I'm done with #281

@Masynchin Masynchin marked this pull request as ready for review March 11, 2024 14:12
@Masynchin
Copy link
Contributor Author

Masynchin commented Mar 11, 2024 •
edited
Loading

@lenguyenthanh I tweaked it and have also:

  • Created createExecutor for ref, so in the tests where ref is used, there is no need now to instantiate client explicitly (now tests are the chains of only <- 🎉).
  • Provided emptyMovesRef alias, so less square brackets overall.

@lenguyenthanh
Copy link
Member

thanks @Masynchin

@lenguyenthanh lenguyenthanh merged commit 8c7f667 into lichess-org:master Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Masynchin @lenguyenthanh