fix(pdf): improve highlight rendering detection and error handling #11908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make PDF annotation detection more robust by checking for PDF-specific properties - Add better error handling and logging for area highlight image loading - Fix issue where highlights without ls-type:annotation weren't showing page refs - Add console debugging to help diagnose highlight rendering issues This fixes cases where PDF highlights (both text and area) weren't rendering properly in blocks, particularly when the ls-type property wasn't set correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
PDF highlights (both text and area) were not rendering correctly in blocks. Users would see the reference but not the highlight content or images. The page reference link (e.g., "P3") was also missing in some cases.
Solution
pdf/hl-page,pdf/hl-type,pdf/hl-value) in addition to thels-type: annotationpropertyChanges
block.cljsto make PDF annotation detection more robustassets.cljsto add better error handling and logging for area displayTesting
ls-typepropertyFixes #[issue-number]