Add SetState to modify the current state #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can see how this can be useful, but I'm afraid that it can also be easily abused. Do you have an idea for another name for the method? The comment should also reflect the fact that no callbacks will be called. |
|
You are right about being abused. Do you have any idea to minimize the risk? About naming, how about SetCurrent, Current, or simply State( ). I am also considering expose allEvents map to the FSM struct's field, so I can check whether the jumping state is valid. How do you think? About comment, I will update as suggested. Thanks. |
|
Hi, any updates for this pull request? |
|
Thanks, and sorry for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some cases, instead of maintaining the state changes, we only need the state diagram. In other words, we allow callers to maintain the state change. Therefore, we allow the caller to modify the current state, so we can jump to a specific state in anytime. In other cases, by opening this API, we can easily implement test cases in different states.