Skip to content

Full unit test coverage on package fsm. #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 9, 2015

Conversation

douglasnaphas
Copy link

I use your FSM package. The branch I am requesting to be merged in to your master branch brings the package to full unit test coverage. The key changes were:

  1. Mock out the FSM's Transition function into an interface, so that I could provide an implementation that would throw an internal error.
  2. Add a unit test file for errors.go. This mostly just checks return strings, but it is nice to have coverage at 100%.

@douglasnaphas
Copy link
Author

I'm not sure what's going on with this check failure.

@tony
Copy link
Contributor

tony commented Jul 21, 2015

Can you trigger a rerun of the tests?

@douglasnaphas
Copy link
Author

I think the only way I can trigger a re-run of the tests is to close this pull request and then re-open it. I don't see a way for me to trigger a re-run of the tests directly in wercker.

I see that the merge for pull request #9 failed with the same error as mine, go install golang.org/x/tools/cmd/cover: open /usr/local/go/pkg/tool/linux_amd64/cover: permission denied. Have there been changes to the build setup in wercker since then that might address the problem?

Let me know if I should close this pull request and open it again to trigger a re-run of the tests.

@maxekman
Copy link
Member

maxekman commented Nov 9, 2015

If you rebase and push, will it re run the tests then? I have merged a minor PR since this.

maxekman added a commit that referenced this pull request Nov 9, 2015
Full unit test coverage on package fsm.
@maxekman maxekman merged commit c77ccaa into looplab:master Nov 9, 2015
@maxekman
Copy link
Member

maxekman commented Nov 9, 2015

I was able to rerun the tests, thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants