Skip to content

race fixes #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 2, 2023
Merged

race fixes #94

merged 4 commits into from
Feb 2, 2023

Conversation

eminden
Copy link
Contributor

@eminden eminden commented Jan 24, 2023

No description provided.

@coveralls
Copy link

coveralls commented Jan 25, 2023

Coverage Status

Coverage: 92.644% (-0.02%) from 92.661% when pulling 807460d on AbExCapital:race-fixes into 525a1dd on looplab:main.

@maxekman
Copy link
Member

Looks valuable, but could you shortly describe the issue and the solution? Thanks

@eminden
Copy link
Contributor Author

eminden commented Jan 26, 2023

Sorry for being late on the description, v1.0.0 is having data races, it can be clearly seen with the existing test cases when you run with -race flag, this pr solves the data races.

Could you please push a new release after merging this pr if you are happy to do so?

@maxekman
Copy link
Member

Thanks for the description! Would you mind adding the -race flag in this PR too? Just to catch stuff in the future.

I'll release a patch after this.

@eminden
Copy link
Contributor Author

eminden commented Jan 26, 2023

here it is.

@maxekman
Copy link
Member

Thanks! There is unfortunately another location for CI (not optimal), would you mind updating here too?

https://github.com/looplab/fsm/blob/main/.github/workflows/main.yml#L21

@eminden
Copy link
Contributor Author

eminden commented Jan 30, 2023

sorry for missing that, it's ready now.

@maxekman maxekman merged commit e668a85 into looplab:main Feb 2, 2023
@maxekman
Copy link
Member

maxekman commented Feb 2, 2023

@eminden Thanks for helping out! Here is the patch release: https://github.com/looplab/fsm/releases/tag/v1.0.1

@eminden eminden deleted the race-fixes branch February 2, 2023 10:25
eminden added a commit to AbExCapital/fsm that referenced this pull request Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants