-
Notifications
You must be signed in to change notification settings - Fork 320
race fixes #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
race fixes #94
Conversation
Looks valuable, but could you shortly describe the issue and the solution? Thanks |
Sorry for being late on the description, v1.0.0 is having data races, it can be clearly seen with the existing test cases when you run with -race flag, this pr solves the data races. Could you please push a new release after merging this pr if you are happy to do so? |
Thanks for the description! Would you mind adding the -race flag in this PR too? Just to catch stuff in the future. I'll release a patch after this. |
here it is. |
Thanks! There is unfortunately another location for CI (not optimal), would you mind updating here too? https://github.com/looplab/fsm/blob/main/.github/workflows/main.yml#L21 |
sorry for missing that, it's ready now. |
@eminden Thanks for helping out! Here is the patch release: https://github.com/looplab/fsm/releases/tag/v1.0.1 |
race fixes (looplab#94)
No description provided.