Add uv support and dependency groups #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds support for dependency groups and using uv.lock for environment sync via uv sync, with dev as the default group, and updates docs/tests accordingly.
- Introduce a new
groupsfield inConfig, defaulting to["dev"] - Update
load_config,project_requirements, andprepare_virtualenvto preferuv.lockand runuv syncwith groups/extras - Document the
groupsoption indocs/config.rstand adjust existing tests to include the default group
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| thx/types.py | Added groups: Sequence[str] to Config |
| thx/tests/config.py | Updated all Config(...) instantiations to include groups=["dev"] |
| thx/runner.py | Extended run_command/check_command to accept an env mapping |
| thx/context.py | Added logic to detect uv.lock and run uv sync with groups and extras |
| thx/config.py | Defaulted groups to ["dev"] when loading config |
| docs/config.rst | Documented the new groups attribute |
Comments suppressed due to low confidence (1)
thx/context.py:231
- There aren't any tests covering the
uv.lockbranch inprepare_virtualenv; consider adding a test whereuv.lockexists to verify theuv syncinvocation with groups and extras.
if requirements and requirements[0].name == "uv.lock":
| .. attribute:: extras | ||
| :type: list[str] | ||
|
|
||
| This specifies a list of package "extras" or optional dpendendencies to be |
There was a problem hiding this comment.
There's a typo in the word "dpendendencies"; it should be "dependencies".
Suggested change
| This specifies a list of package "extras" or optional dpendendencies to be | |
| This specifies a list of package "extras" or optional dependencies to be |
Copilot uses AI. Check for mistakes.
|
|
||
| async def check_command(command: Sequence[StrPath]) -> CommandResult: | ||
| result = await run_command(command) | ||
| async def check_command(command: Sequence[StrPath], *, env: Optional[Mapping[str, str]] = None, context: Optional[Context] = None) -> CommandResult: |
There was a problem hiding this comment.
[nitpick] The keyword-only parameters in check_command are ordered as env, context, but run_command uses context, env; consider aligning the order for consistency.
Suggested change
| async def check_command(command: Sequence[StrPath], *, env: Optional[Mapping[str, str]] = None, context: Optional[Context] = None) -> CommandResult: | |
| async def check_command(command: Sequence[StrPath], *, context: Optional[Context] = None, env: Optional[Mapping[str, str]] = None) -> CommandResult: |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
uv.lockover requirements files when syncingTesting
python -m coverage run -m thx.testshttps://chatgpt.com/codex/tasks/task_e_6843f8b83f048328800000335351380c