New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dynamo] Dynamo triggering on list comprehension <listcomp> frames and graph breaking #138654

Closed

anijain2305 opened this issue Oct 22, 2024 · 0 comments

Labels

Contributor

anijain2305 commented Oct 22, 2024 •

edited

Loading

🐛 Describe the bug

Internal xref - https://fb.workplace.com/groups/1075192433118967/permalink/1528968734407999/

import torch


class Module(torch.nn.Module):
    def __init__(self):
        super().__init__()
        self._num = 4

    @torch._dynamo.disable(recursive=False)
    def forward(self, x):
        values = [4 * torch.cos(i) for i in range(self._num)]
        return sum(values) * x

mod = Module()

def fn(x):
    return mod(x)

opt_fn = torch.compile(fn, backend="eager")
opt_fn(torch.randn(4))

Error logs

No response

Minified repro

No response

Versions

NA

cc @ezyang @chauhang @penguinwu

The text was updated successfully, but these errors were encountered:

anijain2305 added the oncall: pt2 label

anijain2305 added a commit that referenced this issue


          [dynamo] Support range_iterator as a function input

c4fbff2

Fixes #138654

[ghstack-poisoned]

anijain2305 mentioned this issue

[dynamo] Support range_iterator as a function input #138657

Closed

anijain2305 added a commit that referenced this issue


          Update on "[dynamo] Support range_iterator as a function input"

e6b62f7

Fixes #138654

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec

[ghstack-poisoned]

anijain2305 added a commit that referenced this issue


          Update base for Update on "[dynamo] Support range_iterator as a funct…

3b8324a

…ion input"

Fixes #138654

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec

[ghstack-poisoned]

anijain2305 added a commit that referenced this issue


          Update on "[dynamo] Support range_iterator as a function input"

11d64f3

Fixes #138654

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec

[ghstack-poisoned]

anijain2305 added a commit that referenced this issue


          Update base for Update on "[dynamo] Support range_iterator as a funct…

4e66ff9

…ion input"

Fixes #138654

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec

[ghstack-poisoned]

anijain2305 added a commit that referenced this issue


          Update on "[dynamo] Support range_iterator as a function input"

0440dd5

Fixes #138654

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec

[ghstack-poisoned]

anijain2305 added a commit that referenced this issue


          Update base for Update on "[dynamo] Support range_iterator as a funct…

c805367

…ion input"

Fixes #138654

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec

[ghstack-poisoned]

anijain2305 added a commit that referenced this issue


          Update on "[dynamo] Support range_iterator as a function input"

e6d10a4

Fixes #138654

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec

[ghstack-poisoned]

anijain2305 added a commit that referenced this issue


          Update base for Update on "[dynamo] Support range_iterator as a funct…

e91ffac

…ion input"

Fixes #138654

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec

[ghstack-poisoned]

anijain2305 added a commit that referenced this issue


          Update on "[dynamo] Support range_iterator as a function input"

eb5032d

Fixes #138654

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec

[ghstack-poisoned]

anijain2305 added a commit that referenced this issue


          Update base for Update on "[dynamo] Support range_iterator as a funct…

0b8b85a

…ion input"

Fixes #138654

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec

[ghstack-poisoned]

anijain2305 added a commit that referenced this issue


          Update on "[dynamo] Support range_iterator as a function input"

1cd10bb

Fixes #138654

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec

[ghstack-poisoned]

pytorchmergebot closed this as completed in

b1acd09

facebook-github-bot pushed a commit to pytorch/benchmark that referenced this issue


          Support range_iterator as a function input (#138657)

367b6ef

Summary:
Fixes pytorch/pytorch#138654

X-link: pytorch/pytorch#138657
Approved by: https://github.com/williamwen42, https://github.com/jansel

Reviewed By: wdvr

Differential Revision: D64881833

Pulled By: anijain2305

fbshipit-source-id: 46bcffa12ef2bec0ff47a1b60323aacbb3a90872

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment