Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Reland 1] Cleanup header inclusions in torch_cpu by iwyu #112311

Closed
wants to merge 1 commit into from
Closed

[Reland 1] Cleanup header inclusions in torch_cpu by iwyu #112311

wants to merge 1 commit into from

Conversation

cyyever
Copy link
Collaborator

@cyyever cyyever commented Oct 28, 2023 •
edited
Loading

Reland #101178 to use IWYU on torch_cpu. The header file changes are excluded to avoid breaking internal jobs.

cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @EikanWang @ezyang

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 28, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/112311

Note: Links to docs will display an error until the docs builds have been completed.

❌ 9 New Failures, 1 Unrelated Failure

As of commit 15628ba with merge base d40d270 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels Oct 28, 2023
@github-actions github-actions bot added module: cpu CPU specific problem (e.g., perf, algorithm) NNC release notes: quantization release notes category ciflow/inductor labels Oct 28, 2023
@cyyever cyyever marked this pull request as draft October 28, 2023 01:50
@cyyever cyyever force-pushed the iwyu4_reland branch 2 times, most recently from 57fcc13 to 842fe64 Compare October 28, 2023 01:57
@cyyever cyyever marked this pull request as ready for review October 28, 2023 02:31
@cyyever
Copy link
Collaborator Author

cyyever commented Oct 28, 2023

@pytorchbot clflow/trunk

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 28, 2023

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: argument command: invalid choice: 'clflow/trunk' (choose from 'merge', 'revert', 'rebase', 'label', 'drci')

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci} ...

Try @pytorchbot --help for more info.

@cyyever
Copy link
Collaborator Author

cyyever commented Oct 28, 2023

@pytorchbot clflow/binaries

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 28, 2023

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: argument command: invalid choice: 'clflow/binaries' (choose from 'merge', 'revert', 'rebase', 'label', 'drci')

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci} ...

Try @pytorchbot --help for more info.

@cyyever
Copy link
Collaborator Author

cyyever commented Oct 28, 2023

@pytorchbot label clflow/trunk

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 28, 2023

Didn't find following labels among repository labels: clflow/trunk

@cyyever
Copy link
Collaborator Author

cyyever commented Oct 28, 2023

@pytorchbot label ciflow/trunk

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 28, 2023
@cyyever
Copy link
Collaborator Author

cyyever commented Oct 28, 2023

@pytorchbot label ciflow/binaries

@pytorch-bot pytorch-bot bot added the ciflow/binaries Trigger all binary build and upload jobs on the PR label Oct 28, 2023
@cyyever cyyever marked this pull request as draft October 28, 2023 06:05
@cyyever cyyever marked this pull request as ready for review November 2, 2023 14:26
@jbschlosser jbschlosser added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Nov 2, 2023
@cyyever
Copy link
Collaborator Author

cyyever commented Nov 18, 2023

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased iwyu4_reland onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout iwyu4_reland && git pull --rebase)

@ezyang
Copy link
Contributor

ezyang commented Nov 19, 2023

@pytorchbot merge -f "windows failures are spurious"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@cyyever cyyever deleted the iwyu4_reland branch November 19, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezyang ezyang ezyang approved these changes

@kulinseth kulinseth Awaiting requested review from kulinseth

@mrshenli mrshenli Awaiting requested review from mrshenli

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

@rohan-varma rohan-varma Awaiting requested review from rohan-varma

@H-Huang H-Huang Awaiting requested review from H-Huang

@awgu awgu Awaiting requested review from awgu

@kwen2501 kwen2501 Awaiting requested review from kwen2501

@wanchaol wanchaol Awaiting requested review from wanchaol

@fegin fegin Awaiting requested review from fegin

@fduwjj fduwjj Awaiting requested review from fduwjj

@kiukchung kiukchung Awaiting requested review from kiukchung

@d4l3k d4l3k Awaiting requested review from d4l3k

@wz337 wz337 Awaiting requested review from wz337

@jerryzh168 jerryzh168 Awaiting requested review from jerryzh168 jerryzh168 is a code owner

@salilsdesai salilsdesai Awaiting requested review from salilsdesai salilsdesai is a code owner

@kimishpatel kimishpatel Awaiting requested review from kimishpatel kimishpatel is a code owner

@digantdesai digantdesai Awaiting requested review from digantdesai digantdesai is a code owner

@jianyuh jianyuh Awaiting requested review from jianyuh jianyuh is a code owner

Assignees
No one assigned
Labels
ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/inductor ciflow/mps Run MPS tests (subset of trunk) ciflow/trunk Trigger trunk jobs on your pull request Merged module: cpu CPU specific problem (e.g., perf, algorithm) NNC open source release notes: mps Release notes category release notes: quantization release notes category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cyyever @pytorchmergebot @ezyang @pytorchbot @jbschlosser