Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #117011: add the TORCH_CHECK(grad_output) of upsample_nearest::backward() #117100

Conversation

CaesarKingW
Copy link
Contributor

add the TORCH_CHECK(grad_output) of upsample_nearest::backward()

Fixes #117011

Copy link

linux-foundation-easycla bot commented Jan 10, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: CaesarKingW / name: 王康 (c05ea44)

@pytorch-bot pytorch-bot bot added the release notes: cuda release notes category label Jan 10, 2024
Copy link

pytorch-bot bot commented Jan 10, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/117100

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit c05ea44 with merge base 19e93b8 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@CaesarKingW CaesarKingW marked this pull request as draft January 11, 2024 06:28
@CaesarKingW CaesarKingW marked this pull request as ready for review January 11, 2024 06:31
@bdhirsh bdhirsh requested a review from lezcano January 11, 2024 15:18
@bdhirsh bdhirsh added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jan 11, 2024
Copy link
Collaborator

@lezcano lezcano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@lezcano
Copy link
Collaborator

lezcano commented Jan 11, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 11, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: cuda release notes category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
5 participants