[export][reland] Disable exported_program.call #120019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

angelayi wants to merge 1 commit into pytorch:main from angelayi:export-D53827930

Contributor

angelayi commented Feb 15, 2024 •

edited by pytorch-bot bot

Loading

Summary: Reland of D53075378 / #119466

Test Plan: CI

Differential Revision: D53827930

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov @ColinPeppler @amjames @desertfire @chauhang

angelayi requested review from avikchaudhuri, gmagogsfm, tugsbayasgalan, zhxchen17, BowenBao, abock, thiagocrepaldi and wschin as code owners

February 15, 2024 21:50

pytorch-bot bot commented Feb 15, 2024 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/120019

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit 005f71f with merge base eba28a6 ():

FLAKY - The following job failed but was likely due to flakiness present on trunk:

Lint / lintrunner-noclang / linux-job (gh)

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

pull / linux-focal-cuda12.1-py3.10-gcc9-sm86 / test (default, 1, 5, linux.g5.4xlarge.nvidia.gpu) (gh)
inductor/test_triton_kernels.py::KernelTests::test_triton_kernel_equal_to_1_arg_dynamic_False

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot bot added the release notes: onnx label

Contributor

facebook-github-bot commented Feb 15, 2024

This pull request was exported from Phabricator. Differential Revision: D53827930

facebook-github-bot added the fb-exported label

github-actions bot added the module: dynamo label

angelayi force-pushed the export-D53827930 branch from e2165b8 to c74a6e9 Compare

February 16, 2024 16:38

Contributor

facebook-github-bot commented Feb 16, 2024

This pull request was exported from Phabricator. Differential Revision: D53827930

angelayi added a commit to angelayi/executorch-1 that referenced this pull request


          Disable exported_program.__call__ (pytorch#1994)

bc5e25a

Summary:
X-link: pytorch/pytorch#120019


Reland of D53075378 / pytorch/pytorch#119466

Reviewed By: suo

Differential Revision: D53827930

angelayi force-pushed the export-D53827930 branch from c74a6e9 to fc8df39 Compare

February 16, 2024 16:39

Contributor

facebook-github-bot commented Feb 16, 2024

This pull request was exported from Phabricator. Differential Revision: D53827930

angelayi force-pushed the export-D53827930 branch from fc8df39 to 6cb2072 Compare

February 20, 2024 22:24

angelayi added a commit to angelayi/executorch-1 that referenced this pull request


          Disable exported_program.__call__ (pytorch#1994)

cf46357

Summary:
X-link: pytorch/pytorch#120019


Reland of D53075378 / pytorch/pytorch#119466

Reviewed By: suo

Differential Revision: D53827930

Contributor

facebook-github-bot commented Feb 20, 2024

This pull request was exported from Phabricator. Differential Revision: D53827930

angelayi added a commit to angelayi/executorch-1 that referenced this pull request


          Disable exported_program.__call__ (pytorch#1994)

cc2dfc8

Summary:
X-link: pytorch/pytorch#120019


Reland of D53075378 / pytorch/pytorch#119466

Reviewed By: suo

Differential Revision: D53827930

angelayi force-pushed the export-D53827930 branch from 6cb2072 to 0ded951 Compare

February 20, 2024 22:25

Contributor

facebook-github-bot commented Feb 20, 2024

This pull request was exported from Phabricator. Differential Revision: D53827930

angelayi added a commit to angelayi/executorch-1 that referenced this pull request


          Disable exported_program.__call__ (pytorch#1994)

90b4f4b

Summary:
X-link: pytorch/pytorch#120019


Reland of D53075378 / pytorch/pytorch#119466

Reviewed By: suo

Differential Revision: D53827930

angelayi force-pushed the export-D53827930 branch from 0ded951 to b0c4b9a Compare

February 22, 2024 00:06

angelayi force-pushed the export-D53827930 branch from e0f9326 to 069977f Compare

March 4, 2024 17:39

Contributor

facebook-github-bot commented Mar 4, 2024

This pull request was exported from Phabricator. Differential Revision: D53827930

angelayi force-pushed the export-D53827930 branch from 069977f to 7555975 Compare

March 4, 2024 20:56

Contributor

facebook-github-bot commented Mar 4, 2024

This pull request was exported from Phabricator. Differential Revision: D53827930

angelayi force-pushed the export-D53827930 branch from 7555975 to bb3a183 Compare

March 4, 2024 20:57

Contributor

facebook-github-bot commented Mar 4, 2024

This pull request was exported from Phabricator. Differential Revision: D53827930

angelayi force-pushed the export-D53827930 branch from bb3a183 to 75ee30e Compare

March 4, 2024 22:48

angelayi added a commit to angelayi/executorch-1 that referenced this pull request


          Disable exported_program.__call__ (pytorch#1994)

7a6d8db

Summary:
X-link: pytorch/pytorch#120019


Reland of D53075378 / pytorch/pytorch#119466

Reviewed By: suo

Differential Revision: D53827930

Contributor

facebook-github-bot commented Mar 4, 2024

This pull request was exported from Phabricator. Differential Revision: D53827930


          [export][reland] Disable exported_program.__call__ (pytorch#120019)

005f71f

Summary:

X-link: pytorch/executorch#1994

Reland of D53075378 / pytorch#119466

Test Plan: CI

Reviewed By: suo

Differential Revision: D53827930

angelayi added a commit to angelayi/executorch-1 that referenced this pull request


          Disable exported_program.__call__ (pytorch#1994)

091b4c1

Summary:
X-link: pytorch/pytorch#120019


Reland of D53075378 / pytorch/pytorch#119466

Reviewed By: suo

Differential Revision: D53827930

angelayi force-pushed the export-D53827930 branch from 75ee30e to 005f71f Compare

March 4, 2024 22:51

Contributor

facebook-github-bot commented Mar 4, 2024

This pull request was exported from Phabricator. Differential Revision: D53827930

facebook-github-bot pushed a commit to pytorch/executorch that referenced this pull request


          Disable exported_program.__call__ (#1994)

10e2510

Summary:
X-link: pytorch/pytorch#120019

Pull Request resolved: #1994

Reland of D53075378 / pytorch/pytorch#119466

Reviewed By: suo

Differential Revision: D53827930

fbshipit-source-id: 83554c86ea320a4d00c781c10bcfa71d6c3e6471

Contributor

facebook-github-bot commented Mar 5, 2024

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

pytorchmergebot added the merging label

Collaborator

pytorchmergebot commented Mar 5, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot closed this in

4b49bc1

pytorchmergebot added Merged and removed merging labels

Contributor Author

angelayi commented Mar 5, 2024

Lintrunner fix here: #121205

jfix71 mentioned this pull request

[exported_program] Remove _postprocess_graph_module_outputs #158059

Closed

pytorch-bot bot pushed a commit that referenced this pull request


          [exported_program] Remove _postprocess_graph_module_outputs

f44097b

Summary: Appears to be dead as of #120019.

Test Plan:
CI

Rollback Plan:

Differential Revision: D78112302

pytorchmergebot pushed a commit that referenced this pull request


          [exported_program] Remove _postprocess_graph_module_outputs (#158059)

dd93883

Summary: Appears to be dead as of #120019.

Test Plan:
CI

Rollback Plan:

Differential Revision: D78112302

Pull Request resolved: #158059
Approved by: https://github.com/angelayi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ydwu4 ydwu4 approved these changes

avikchaudhuri Awaiting requested review from avikchaudhuri avikchaudhuri is a code owner

gmagogsfm Awaiting requested review from gmagogsfm

tugsbayasgalan Awaiting requested review from tugsbayasgalan tugsbayasgalan is a code owner

zhxchen17 Awaiting requested review from zhxchen17 zhxchen17 is a code owner

BowenBao Awaiting requested review from BowenBao

abock Awaiting requested review from abock

thiagocrepaldi Awaiting requested review from thiagocrepaldi

wschin Awaiting requested review from wschin

Labels

ciflow/inductor ciflow/trunk fb-exported Merged module: dynamo module: inductor release notes: onnx