[ROCm] Add cublasGemmAlgo_t -> hipblasGemmAlgo_t #121030

rraminen · 2024-03-01T18:56:02Z

This PR is to add cublasGemmAlgo_t -> hipblasGemmAlgo_t to cuda_to_hip_mappings.py.
It is required for DeepSpeed transformer extension build on ROCm.

cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang

pytorch-bot · 2024-03-01T18:56:06Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/121030

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit f153dcf with merge base 2b82345 ():

FLAKY - The following job failed but was likely due to flakiness present on trunk:

pull / linux-focal-py3.12-clang10 / test (dynamo, 3, 3, linux.2xlarge) (gh)
functorch/test_aotdispatch.py::TestPartitioning::test_min_cut_partitioner_save_shape

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot · 2024-03-01T18:56:09Z

Please seek CI approval before scheduling CIFlow labels

ezyang · 2024-03-13T03:32:23Z

need to update the xpass plz

jeffdaily · 2024-03-13T23:28:07Z

@pytorchbot rebase

pytorchmergebot · 2024-03-13T23:30:19Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot · 2024-03-13T23:30:23Z

Successfully rebased add_hipblasGemmAlgo_t onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout add_hipblasGemmAlgo_t && git pull --rebase)

rraminen · 2024-04-18T16:03:52Z

@pytorchbot rebase

pytorchmergebot · 2024-04-18T16:05:28Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot · 2024-04-18T16:05:34Z

Successfully rebased add_hipblasGemmAlgo_t onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout add_hipblasGemmAlgo_t && git pull --rebase)

jithunnair-amd · 2024-04-18T16:09:31Z

@rraminen This is a very minor change, so I'm issuing a merge command assuming CI jobs should pass fine.

@pytorchbot merge

pytorchmergebot · 2024-04-18T16:11:18Z

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team

Raised by workflow job

jithunnair-amd · 2024-04-18T16:12:28Z

@pytorchbot merge

pytorchmergebot · 2024-04-18T16:14:14Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-04-18T17:56:58Z

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

pull / linux-jammy-py3.8-gcc11-no-ops / build

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

ezyang · 2024-04-19T01:02:33Z

@pytorchbot merge

pytorchmergebot · 2024-04-19T01:04:10Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

This PR is to add cublasGemmAlgo_t -> hipblasGemmAlgo_t to cuda_to_hip_mappings.py. It is required for DeepSpeed transformer extension build on ROCm. Pull Request resolved: pytorch#121030 Approved by: https://github.com/jeffdaily, https://github.com/ezyang

Fixes #4989 In addition to this PR, below changes are required to build below extensions successfully. Please note that not all unit tests for these extensions will pass with this PR. More details on the unit test results are below. These unit tests are skipped in CI anyway, so they will not break the CI. - transformer_inference - quantizer - random_ltd - pytorch/pytorch#121030 - #5402 Unit test results (rocm/pytorch:rocm6.1_ubuntu20.04_py3.9_pytorch_2.1.2) on MI200: **transformer_inference:** pytest --color=yes --durations=0 --verbose -s -m "inference_ops" -rF -n 4 unit/ops/transformer/inference Before this PR: ==== 674 failed, 622 skipped, 8 warnings, 1728 errors in 123.66s (0:02:03) ===== After this PR: ========== 555 failed, 983 passed, 1486 skipped, 8 warnings in 14.35s ========== **quantizer:** pytest --color=yes --durations=0 --verbose -s -m "inference_ops" -rF -n 4 unit/ops/quantizer Before this PR: ==== 244 failed, 8 warnings in 48.02s ==== After this PR: ===== 187 failed, 57 passed, 8 warnings in 14.74s ==== I could not find random_ltd related unit tests to run. --------- Co-authored-by: Logan Adams <114770087+loadams@users.noreply.github.com> Co-authored-by: Logan Adams <loadams@microsoft.com>

Fixes deepspeedai#4989 In addition to this PR, below changes are required to build below extensions successfully. Please note that not all unit tests for these extensions will pass with this PR. More details on the unit test results are below. These unit tests are skipped in CI anyway, so they will not break the CI. - transformer_inference - quantizer - random_ltd - pytorch/pytorch#121030 - deepspeedai#5402 Unit test results (rocm/pytorch:rocm6.1_ubuntu20.04_py3.9_pytorch_2.1.2) on MI200: **transformer_inference:** pytest --color=yes --durations=0 --verbose -s -m "inference_ops" -rF -n 4 unit/ops/transformer/inference Before this PR: ==== 674 failed, 622 skipped, 8 warnings, 1728 errors in 123.66s (0:02:03) ===== After this PR: ========== 555 failed, 983 passed, 1486 skipped, 8 warnings in 14.35s ========== **quantizer:** pytest --color=yes --durations=0 --verbose -s -m "inference_ops" -rF -n 4 unit/ops/quantizer Before this PR: ==== 244 failed, 8 warnings in 48.02s ==== After this PR: ===== 187 failed, 57 passed, 8 warnings in 14.74s ==== I could not find random_ltd related unit tests to run. --------- Co-authored-by: Logan Adams <114770087+loadams@users.noreply.github.com> Co-authored-by: Logan Adams <loadams@microsoft.com>

rraminen requested review from jeffdaily and jithunnair-amd as code owners March 1, 2024 18:56

pytorch-bot bot added ciflow/rocm Trigger "default" config CI on ROCm module: rocm AMD GPU support for Pytorch labels Mar 1, 2024

pytorch-bot bot removed the ciflow/rocm Trigger "default" config CI on ROCm label Mar 1, 2024

pytorchbot added the open source label Mar 1, 2024

jeffdaily approved these changes Mar 4, 2024

View reviewed changes

jeffdaily added ciflow/trunk Trigger trunk jobs on your pull request ciflow/rocm Trigger "default" config CI on ROCm labels Mar 4, 2024

jithunnair-amd requested review from malfet and ezyang March 11, 2024 21:18

ezyang approved these changes Mar 13, 2024

View reviewed changes

pytorchmergebot force-pushed the add_hipblasGemmAlgo_t branch from 1884588 to e3a1547 Compare March 13, 2024 23:30

Added cublasGemmAlgo_t -> hipblasGemmAlgo_t

f153dcf

pytorchmergebot force-pushed the add_hipblasGemmAlgo_t branch from e3a1547 to f153dcf Compare April 18, 2024 16:05

pytorchmergebot added the merging label Apr 18, 2024

pytorchmergebot removed the merging label Apr 18, 2024

jithunnair-amd added the topic: not user facing topic category label Apr 18, 2024

pytorchmergebot added the merging label Apr 18, 2024

pytorchmergebot removed the merging label Apr 18, 2024

pytorchmergebot added the merging label Apr 19, 2024

pytorchmergebot added the Merged label Apr 19, 2024

pytorchmergebot closed this in 803a08f Apr 19, 2024

pytorchmergebot removed the merging label Apr 19, 2024

rraminen mentioned this pull request Apr 23, 2024

rocblas -> hipblas changes for ROCm deepspeedai/DeepSpeed#5401

Merged

jithunnair-amd mentioned this pull request May 16, 2024

[v2.3.1] Release Tracker #125425

Closed

[ROCm] Add cublasGemmAlgo_t -> hipblasGemmAlgo_t #121030

[ROCm] Add cublasGemmAlgo_t -> hipblasGemmAlgo_t #121030

Uh oh!

Conversation

rraminen commented Mar 1, 2024 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Mar 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/121030

✅ You can merge normally! (1 Unrelated Failure)

Uh oh!

pytorch-bot bot commented Mar 1, 2024

Uh oh!

ezyang commented Mar 13, 2024

Uh oh!

jeffdaily commented Mar 13, 2024

Uh oh!

pytorchmergebot commented Mar 13, 2024

Uh oh!

pytorchmergebot commented Mar 13, 2024

Uh oh!

rraminen commented Apr 18, 2024

Uh oh!

pytorchmergebot commented Apr 18, 2024

Uh oh!

pytorchmergebot commented Apr 18, 2024

Uh oh!

jithunnair-amd commented Apr 18, 2024

Uh oh!

pytorchmergebot commented Apr 18, 2024

Merge failed

Uh oh!

jithunnair-amd commented Apr 18, 2024

Uh oh!

pytorchmergebot commented Apr 18, 2024

Merge started

Uh oh!

pytorchmergebot commented Apr 18, 2024

Merge failed

Uh oh!

ezyang commented Apr 19, 2024

Uh oh!

pytorchmergebot commented Apr 19, 2024

Merge started

Uh oh!

Uh oh!

rraminen commented Mar 1, 2024 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented Mar 1, 2024 •

edited

Loading