Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Globally enable Python dispatcher for all of Inductor compilation #137621

Open
wants to merge 3 commits into
base: gh/ezyang/2958/base
Choose a base branch
from
Open

Globally enable Python dispatcher for all of Inductor compilation #137621

wants to merge 3 commits into from

Conversation

ezyang
Copy link
Contributor

@ezyang ezyang commented Oct 9, 2024 •
edited by pytorch-bot bot
Loading

@ezyang
Update
4dea75a 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Oct 9, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137621

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 74e6474 with merge base 9af1816 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ezyang added a commit that referenced this pull request Oct 9, 2024
@ezyang
Globally enable Python dispatcher for all of Inductor compilation
8e7e037 
Signed-off-by: Edward Z. Yang <ezyang@meta.com>

ghstack-source-id: db3c40f86dc6dfa6c419ec5b397b266500663626
Pull Request resolved: #137621
@albanD albanD removed their request for review October 9, 2024 19:06
@ezyang ezyang added topic: not user facing topic category ciflow/trunk Trigger trunk jobs on your pull request labels Oct 12, 2024
@ezyang
Update
375241d 
[ghstack-poisoned]
@ezyang
Copy link
Contributor Author

ezyang commented Oct 12, 2024

this is ready

ezyang added a commit that referenced this pull request Oct 12, 2024
@ezyang
Globally enable Python dispatcher for all of Inductor compilation
30c30ef 
Signed-off-by: Edward Z. Yang <ezyang@meta.com>

ghstack-source-id: 6ad1b88274f578339879f9fe4e16e1ae987296b9
Pull Request resolved: #137621
@ezyang ezyang requested a review from eellison October 28, 2024 13:49
eellison
eellison reviewed Oct 28, 2024
View reviewed changes
Copy link
Contributor

@eellison eellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a bunch of failures when I enable py dispatch in fake tensor mode lol #138953

@ezyang
Copy link
Contributor Author

ezyang commented Oct 29, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x 30c30efc651f60b4bf17e7f76f54154d8ced7435 returned non-zero exit code 1

Auto-merging torch/_inductor/compile_fx.py
CONFLICT (content): Merge conflict in torch/_inductor/compile_fx.py
error: could not apply 30c30efc65... Globally enable Python dispatcher for all of Inductor compilation
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Details for Dev Infra team Raised by workflow job

@ezyang
Update
74e6474 
[ghstack-poisoned]
ezyang added a commit that referenced this pull request Oct 29, 2024
@ezyang
Globally enable Python dispatcher for all of Inductor compilation
98eada0 
Signed-off-by: Edward Z. Yang <ezyang@meta.com>

ghstack-source-id: e7472887b44454bc884035a69b473e0d4dbc2ce6
Pull Request resolved: #137621
@ezyang
Copy link
Contributor Author

ezyang commented Oct 29, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eellison eellison eellison approved these changes

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@bdhirsh bdhirsh Awaiting requested review from bdhirsh

@miladm miladm Awaiting requested review from miladm

@SherlockNoMad SherlockNoMad Awaiting requested review from SherlockNoMad

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request merging module: inductor topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ezyang @pytorchmergebot @eellison