Add Intel GPU info collection to the collect env script #137846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137846
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 2 Cancelled Jobs, 1 Unrelated FailureAs of commit dc8231a with merge base a777dea ( NEW FAILURES - The following jobs have failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot label "topic: not user facing" |
0f6eaa9
to
f1cf6ec
Compare
malfet
reviewed
Oct 18, 2024
torch/utils/collect_env.py
Outdated
Comment on lines
495
to
503
| ret = run_and_read_all( | ||
| run_lambda, | ||
| 'powershell.exe "gwmi -Class Win32_OperatingSystem | Select-Object -Property Caption,\ | ||
| OSArchitecture,Version | ConvertTo-Json"', | ||
| ) | ||
| try: | ||
| obj = json.loads(ret) | ||
| ret = f'{obj["Caption"]} ({obj["Version"]} {obj["OSArchitecture"]})' | ||
| except ValueError as e: |
There was a problem hiding this comment.
Can you please land this one as separate PR
malfet
reviewed
Oct 18, 2024
| @@ -146,7 +151,7 @@ def get_nvidia_driver_version(run_lambda): | |||
| return run_and_parse_first_match(run_lambda, smi, r'Driver Version: (.*?) ') | |||
|
|
|||
|
|
|||
| def get_gpu_info(run_lambda): | |||
| def get_nvidia_gpu_info(run_lambda): | |||
There was a problem hiding this comment.
Please don't delete any existing functions, as this might be considered a public API change
malfet
reviewed
Oct 18, 2024
torch/utils/collect_env.py
Outdated
Comment on lines
238
to
257
| if mgr_name == "": | ||
| rc, _, _ = run("which dpkg") | ||
| if rc == 0: | ||
| mgr_name = "dpkg" | ||
| if mgr_name == "": | ||
| rc, _, _ = run("which dnf") | ||
| if rc == 0: | ||
| mgr_name = "dnf" | ||
| if mgr_name == "": | ||
| rc, _, _ = run("which yum") | ||
| if rc == 0: | ||
| mgr_name = "yum" | ||
| if mgr_name == "": | ||
| rc, _, _ = run("which zypper") | ||
| if rc == 0: | ||
| mgr_name = "zypper" |
There was a problem hiding this comment.
Please Avoid code duplication, use loops
Suggested change
| if mgr_name == "": | |
| rc, _, _ = run("which dpkg") | |
| if rc == 0: | |
| mgr_name = "dpkg" | |
| if mgr_name == "": | |
| rc, _, _ = run("which dnf") | |
| if rc == 0: | |
| mgr_name = "dnf" | |
| if mgr_name == "": | |
| rc, _, _ = run("which yum") | |
| if rc == 0: | |
| mgr_name = "yum" | |
| if mgr_name == "": | |
| rc, _, _ = run("which zypper") | |
| if rc == 0: | |
| mgr_name = "zypper" | |
| for mgr_name in ["dpkg", "dnf", "yum", "zypper", ""]: | |
| if mgr_name == "": | |
| continue | |
| rc, _, _ = run(f"which {mgr_name}") | |
| if rc == 0: | |
| break |
77fb09d
to
dc8231a
Compare
|
The CI doesn't seem to use 2.5. Offline testing with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wmicis deprecated on Windows, this PR updates the usage ofwmicto its counterpart inpowershell. WMI command line (WMIC) utility deprecation: Next stepscc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang