Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix trace nn.parameters() #138149

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix trace nn.parameters() #138149

wants to merge 1 commit into from

Conversation

majian4work
Copy link
Contributor

@majian4work majian4work commented Oct 17, 2024 •
edited by pytorch-bot bot
Loading

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Oct 17, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138149

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 0637472 with merge base d2ec289 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@majian4work
Copy link
Contributor Author

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Oct 17, 2024
@majian4work
Copy link
Contributor Author

@anijain2305 Could you help to take a review?

@janeyx99 janeyx99 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Oct 18, 2024
@majian4work
Copy link
Contributor Author

@anijain2305 @ydwu4
Could you help to retrigger the failed test?

@majian4work
Copy link
Contributor Author

hi @ezyang @chauhang @penguinwu @voznesenskym @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @amjames @rec
anybody can help to take an review.
thanks very much.

@ezyang
Copy link
Contributor

ezyang commented Oct 24, 2024

Can you put your test into the test suite too

@majian4work
Copy link
Contributor Author

Can you put your test into the test suite too

Sure.

@majian4work
Copy link
Contributor Author

@ezyang seems still the same machine

@ezyang
Copy link
Contributor

ezyang commented Oct 27, 2024

@anijain2305 I think I need to defer to you for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anijain2305 anijain2305 Awaiting requested review from anijain2305

@ydwu4 ydwu4 Awaiting requested review from ydwu4

Assignees
No one assigned
Labels
ciflow/inductor module: dynamo oncall: pt2 open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
5 participants
@majian4work @ezyang @pytorchbot @janeyx99 @drisspg