[FSDP] Add support for FSDPCommContext on PrivateUse1 backend
#138687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138687
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 1998fe1 with merge base 72dde6e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
I am ok with this change. Let me know if any of the PrivateUse1 do not support streams and have a comment about this. |
shink
commented
Oct 24, 2024
| @@ -51,7 +51,7 @@ class FSDPCommContext: | |||
|
|
|||
| def lazy_init(self, device: torch.device): | |||
| self.device_handle = _get_device_handle(device.type) | |||
| if device.type not in ["cuda", "hpu"]: | |||
| if device.type not in ["cuda", "hpu", torch._C._get_privateuse1_backend_name()]: | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe NPU supports streams, but what about other privateuse1 backends?
cc: @FFFrog @noemotiovon
cc @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o