Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hop free symbols] replace ctx.save_for_backward to support symints/ints #138737

Open
wants to merge 6 commits into
base: gh/ydwu4/165/base
Choose a base branch
from

Conversation

Copy link

pytorch-bot bot commented Oct 23, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138737

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 25e9c43 with merge base 8fa0479 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@ydwu4 ydwu4 added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 25, 2024
Copy link
Contributor

@Chillee Chillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add some tests in test/inductor/test_flex_attention.py ?

@ydwu4
Copy link
Contributor Author

ydwu4 commented Oct 29, 2024

These are tested on top of the stack but yeah, I can add some

…t symints/ints"

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov

[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request module: inductor topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants