Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check for unsupported sprase layout to resolve false INTERNAL ASSERT FAILED #139198

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add check for unsupported sprase layout to resolve false INTERNAL ASSERT FAILED #139198

wants to merge 2 commits into from
+2 −0

Conversation

jackson-tsang578
Copy link

Fixes #131319. Implemented the check on layout as described in the original issue.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Oct 29, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139198

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit b62630d with merge base ed94725 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@jackson-tsang578 jackson-tsang578 marked this pull request as ready for review October 29, 2024 15:10
@mikaylagawarecki mikaylagawarecki added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Oct 29, 2024
@cpuhrsch cpuhrsch requested a review from pearu October 29, 2024 22:23
@jackson-tsang578 @Skylion007
Change to ValueError
b62630d 
Co-authored-by: Aaron Gokaslan <aaronGokaslan@gmail.com>
@jackson-tsang578
Copy link
Author

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007 Skylion007 left review comments

@lezcano lezcano Awaiting requested review from lezcano lezcano is a code owner

@nikitaved nikitaved Awaiting requested review from nikitaved nikitaved is a code owner

@IvanYashchuk IvanYashchuk Awaiting requested review from IvanYashchuk IvanYashchuk is a code owner

@cpuhrsch cpuhrsch Awaiting requested review from cpuhrsch

@pearu pearu Awaiting requested review from pearu

Assignees
No one assigned
Labels
open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RuntimeError: false INTERNAL ASSERT FAILED at "../aten/src/ATen/native/BatchLinearAlgebra.cpp":498
4 participants
@jackson-tsang578 @Skylion007 @pytorchbot @mikaylagawarecki