Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not print "we strongly recommend" for CPU builds #139243

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Do not print "we strongly recommend" for CPU builds #139243

wants to merge 1 commit into from
+1 −0

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Oct 30, 2024

I.e. check that cmake.get_cmake_cache_variables()["USE_CUDA"] is true before printing the message

Noticed while looking on aarch64 build logs that this warning is printed over and over again, for example

+ python setup.py bad_argument
Building wheel torch-2.6.0a0+git6d9c71a
-------------------------------------------------------------------------------------------------
|                                                                                               |
|            WARNING: we strongly recommend enabling linker script optimization for ARM + CUDA. |
|            To do so please export USE_PRIORITIZED_TEXT_FOR_LD=1                               |
|                                                                                               |
-------------------------------------------------------------------------------------------------
invalid command 'bad_argument'

@malfet
Do not print "we strongly recommend" for CPU builds
8a44f35 
I.e. check that `cmake.get_cmake_cache_variables()["USE_CUDA"]` is true before printing the message
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Oct 30, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139243

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 14 Unrelated Failures

As of commit 8a44f35 with merge base d9e87fb (image):

NEW FAILURE - The following job has failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@malfet malfet requested a review from Aidyn-A October 30, 2024 00:44
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Oct 30, 2024
@malfet malfet requested a review from a team October 30, 2024 00:44
@malfet malfet added release notes: build release notes category topic: improvements topic category ciflow/linux-aarch64 linux aarch64 CI workflow labels Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kit1980 kit1980 kit1980 approved these changes

@Skylion007 Skylion007 Skylion007 approved these changes

@Aidyn-A Aidyn-A Awaiting requested review from Aidyn-A

Assignees
No one assigned
Labels
ciflow/linux-aarch64 linux aarch64 CI workflow release notes: build release notes category topic: improvements topic category topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@malfet @kit1980 @Skylion007