-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not print "we strongly recommend" for CPU builds #139243
Open
malfet
wants to merge
1
commit into
main
Choose a base branch
from
malfet-patch-25
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I.e. check that `cmake.get_cmake_cache_variables()["USE_CUDA"]` is true before printing the message
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139243
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 14 Unrelated FailuresAs of commit 8a44f35 with merge base d9e87fb (): NEW FAILURE - The following job has failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
malfet
added
release notes: build
release notes category
topic: improvements
topic category
ciflow/linux-aarch64
linux aarch64 CI workflow
labels
Oct 30, 2024
kit1980
approved these changes
Oct 30, 2024
Skylion007
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ciflow/linux-aarch64
linux aarch64 CI workflow
release notes: build
release notes category
topic: improvements
topic category
topic: not user facing
topic category
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I.e. check that
cmake.get_cmake_cache_variables()["USE_CUDA"]
is true before printing the messageNoticed while looking on aarch64 build logs that this warning is printed over and over again, for example