Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix existing lint issues in ir.py #139237

Open
wants to merge 3 commits into
base: gh/aorenste/142/base
Choose a base branch
from
Open

Fix existing lint issues in ir.py #139237

wants to merge 3 commits into from
+56 −60

Conversation

aorenste
Copy link
Contributor

@aorenste aorenste commented Oct 29, 2024 •
edited
Loading

@aorenste
Fix existing mypy issues
bdfbffa 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Oct 29, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139237

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 1 Pending, 16 Unrelated Failures

As of commit 56d7b6e with merge base bd369bb (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Oct 29, 2024
Open
Open
@aorenste aorenste changed the title Fix existing mypy issues Fix existing lint issues in ir.py Oct 29, 2024
@aorenste aorenste added the topic: not user facing topic category label Oct 29, 2024
@aorenste
Update on "Fix existing lint issues in ir.py"
12af82c 
- Remove stale mypy "type: ignores"
- Made ir.py pass the rest of the lints




cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov

[ghstack-poisoned]
@aorenste
Update on "Fix existing lint issues in ir.py"
56d7b6e 
- Remove stale mypy "type: ignores"
- Made ir.py pass the rest of the lints




cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov

[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

Assignees
No one assigned
Labels
ciflow/inductor module: inductor topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aorenste @Skylion007