Modified the curl|bash code to make it palatable to security-checking… #139311
+179
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our security-checking software balks at the "curl | sudo bash" idiom.
After researching this a lot(!) online, the fix -- when people even acknowledge this needs fixing -- is to manually inspect the download file before allowing it to run each time you want to run the enclosing script.
The better answer, implemented here, is to download the file, check it for naughtiness, and then include it as part of the distribution (that is, add it to the repo). This doesn't magically get you updates, but it can be manually updated as necessary (I'm assuming the downloaded file rarely changes), which is probably the safest thing, anyway.