Skip to content

[LTC] Inherits LazyGraphExecutor #4296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Dec 8, 2022
Merged

[LTC] Inherits LazyGraphExecutor #4296

merged 9 commits into from
Dec 8, 2022

Conversation

alanwaketan
Copy link
Collaborator

Summary:
This patch lets XLAGraphExecutor inherits LazyGraphExecutor. A few things worth noting:

  1. It replaces xla::util::ExceptionCleanup with torch::lazy::ExceptionCleanup.
  2. It uses upstream SyncTensorsConfig, SyncTensorCollection, and PostOrderData.

@alanwaketan alanwaketan added the tracing Lazy Tensor tracing label Dec 7, 2022
@alanwaketan alanwaketan self-assigned this Dec 7, 2022
JackCaoG
JackCaoG approved these changes Dec 7, 2022
View reviewed changes
Copy link
Collaborator

@JackCaoG JackCaoG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alanwaketan
Copy link
Collaborator Author

Thanks, Jack.

@alanwaketan
Copy link
Collaborator Author

Forgot to mention, this pull request depends on pytorch/pytorch#90420.

@alanwaketan
Revert "Add a .torch_pin"
6b4bf58 
This reverts commit 82ddb45.
@alanwaketan alanwaketan merged commit 036728e into master Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackCaoG JackCaoG JackCaoG approved these changes

@wonjoo-wj wonjoo-wj Awaiting requested review from wonjoo-wj

Assignees

@alanwaketan alanwaketan

Labels
REMOVE_TORCH_PIN tracing Lazy Tensor tracing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alanwaketan @JackCaoG