Skip to content

Make cxx_abi enable by default #8844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 18, 2025
Merged

Make cxx_abi enable by default #8844

merged 3 commits into from
Mar 18, 2025

Conversation

zpcore
Copy link
Member

@zpcore zpcore commented Mar 17, 2025 •
edited
Loading

  1. Make cxx_abi flag on by default but still give user option to build with the flag off. When the flag is off, the wheel will append _precxx11 in the naming;
  2. Minor naming fix in the CI;
  3. Add cuda 12.8 in the nightly build since the default CUDA driver in the XLML test VM is 12.8 now.

@zpcore zpcore marked this pull request as ready for review March 17, 2025 21:36
@zpcore zpcore requested review from lsy323 and ManfeiBai as code owners March 17, 2025 21:36
@zpcore zpcore requested review from tengyifei and pgmoka March 17, 2025 21:36
tengyifei
tengyifei approved these changes Mar 17, 2025
View reviewed changes
ManfeiBai
ManfeiBai approved these changes Mar 18, 2025
View reviewed changes
Copy link
Collaborator

@ManfeiBai ManfeiBai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@zpcore zpcore merged commit 8f314a5 into master Mar 18, 2025
23 checks passed
@zpcore zpcore deleted the piz/fix_build branch March 18, 2025 04:09
zpcore added a commit that referenced this pull request Mar 26, 2025
@zpcore
Make cxx_abi enable by default (#8844)
0f41b72
@zpcore zpcore mentioned this pull request Mar 26, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengyifei tengyifei tengyifei approved these changes

@ManfeiBai ManfeiBai ManfeiBai approved these changes

@lsy323 lsy323 Awaiting requested review from lsy323

@pgmoka pgmoka Awaiting requested review from pgmoka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zpcore @tengyifei @ManfeiBai