Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrected ImageCms test #7930

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Corrected ImageCms test #7930

merged 1 commit into from
Apr 1, 2024

Conversation

radarhere
Copy link
Member

Looking at the duplicate code in

Pillow/Tests/test_imagecms.py

Lines 517 to 531 in 63cbfcf

if not is_pypy():
# core profile should not be directly instantiable
with pytest.raises(TypeError):
ImageCms.core.CmsProfile()
with pytest.raises(TypeError):
ImageCms.core.CmsProfile(0)
@pytest.mark.skipif(is_pypy(), reason="fails on PyPy")
def test_transform_typesafety() -> None:
# core transform should not be directly instantiable
with pytest.raises(TypeError):
ImageCms.core.CmsProfile()
with pytest.raises(TypeError):
ImageCms.core.CmsProfile(0)

I think @nulano's intention in #7913 was to test ImageCms.core.CmsTransform in test_transform_typesafety()

@hugovk hugovk merged commit 6b676f2 into python-pillow:main Apr 1, 2024
56 checks passed
@radarhere radarhere deleted the imagecms branch April 1, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nulano nulano nulano approved these changes

Assignees
No one assigned
Labels
Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@radarhere @nulano @hugovk