Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stubsabot] Bump cffi to 1.17.* #12495

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[stubsabot] Bump cffi to 1.17.* #12495

wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 7, 2024

Release: https://pypi.org/pypi/cffi/1.17.1
Homepage: http://cffi.readthedocs.org
Repository: https://foss.heptapod.net/pypy/cffi
Typeshed stubs: https://github.com/python/typeshed/tree/main/stubs/cffi
Changelog: https://cffi.readthedocs.io/en/latest/whatsnew.html

If stubtest fails for this PR:

  • Leave this PR open (as a reminder, and to prevent stubsabot from opening another PR)
  • Fix stubtest failures in another PR, then close this PR

Note that you will need to close and re-open the PR in order to trigger CI

@github-actions github-actions bot added the bot: stubsabot 🤖 PRs created by stubsabot 🤖 label Aug 7, 2024
@AlexWaygood AlexWaygood closed this Aug 7, 2024
@AlexWaygood AlexWaygood reopened this Aug 7, 2024
@srittau
Copy link
Collaborator

srittau commented Aug 7, 2024

From the Changelog:

In API mode, when you get a function from a C library by writing fn = lib.myfunc, you get an object of a special type for performance reasons, instead of a <cdata ‘C-function-type’>. Before version 1.17 you could only call such objects. You could write ffi.addressof(lib, “myfunc”) in order to get a real object, based on the idea that in these cases in C you’d usually write &myfunc instead of myfunc. In version 1.17, the special object lib.myfunc can now be passed in many places where CFFI expects a regular object. For example, you can now pass it as a callback to a C function call, or write it inside a C structure field of the correct pointer-to-function type, or use ffi.cast() or ffi.typeof() on it.

This sounds like it might need some changes to the stubs to accept this special object.

Release: https://pypi.org/pypi/cffi/1.17.1
Homepage: http://cffi.readthedocs.org
Repository: https://foss.heptapod.net/pypy/cffi
Typeshed stubs: https://github.com/python/typeshed/tree/main/stubs/cffi
Changelog: https://cffi.readthedocs.io/en/latest/whatsnew.html

If stubtest fails for this PR:
- Leave this PR open (as a reminder, and to prevent stubsabot from opening another PR)
- Fix stubtest failures in another PR, then close this PR

Note that you will need to close and re-open the PR in order to trigger CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: stubsabot 🤖 PRs created by stubsabot 🤖
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants