-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-103951: enable optimization for fast attribute access on module subclasses #126264
Open
skirpichev
wants to merge
7
commits into
python:main
Choose a base branch
from
skirpichev:opt-mod-loadattr-103951
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+6
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ule subclasses This patch relax specialization requirements from ``PyModule_CheckExact(op)`` to ``Py_TYPE(op)->tp_getattro != PyModule_Type.tp_getattro``. Benchmarks: ```py import pyperf import b import c runner = pyperf.Runner() runner.timeit('b.x', 'b.x', globals=globals()) runner.timeit('c.x', 'c.x', globals=globals()) ``` ```py x = 1 ``` ```py import sys, types x = 1 class _Foo(types.ModuleType): pass sys.modules[__name__].__class__ = _Foo ``` On the main: ``` $ python a.py -q b.x: Mean +- std dev: 50.2 ns +- 2.7 ns c.x: Mean +- std dev: 132 ns +- 7 ns ``` With the patch: ``` $ python a.py -q b.x: Mean +- std dev: 52.9 ns +- 3.6 ns c.x: Mean +- std dev: 52.6 ns +- 2.7 ns ``` Co-authored-by: Nicolas Tessore <n.tessore@ucl.ac.uk>
skirpichev
changed the title
gh-103951: enable optimization for fast attribute access on module su…
gh-103951: enable optimization for fast attribute access on module subclasses
Nov 1, 2024
skirpichev
requested review from
markshannon and
ericsnowcurrently
as code owners
November 1, 2024 07:42
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Fidget-Spinner
approved these changes
Nov 7, 2024
Thanks for the PR @skirpichev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch relax specialization requirements from
PyModule_CheckExact(op)
toPy_TYPE(op)->tp_getattro != PyModule_Type.tp_getattro
.Benchmarks:
On the main:
With the patch: