gh-125911: Rename big trampoline to shim #126339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandtbucher
reviewed
Nov 3, 2024
There was a problem hiding this comment.
This is so much better, thanks. Just one incorrect rename... a testament to how confusing I made this, and how much this change is needed. ;)
@diegorusso: just a heads-up that we're renaming the "big" calling convention trampoline to shim and leaving all of your new "little" range-extending trampolines as trampoline.
|
Yes, I agree with the change. In fact I always called the "other trampoline" :) Thanks Savannah for the change, it LGTM. 🎉 |
brandtbucher
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I did this correctly/caught everything 😅. Basically, I renamed the
trampolineassociated with the StencilGroup (aka big trampoline) toshimand then left the rest astrampolinesas those refer the little trampolines needed to compile a trace.combine_symbol_maskon the initial trampoline for a trace #125911