Skip to content

Clarify support for multiple worker processes in Procfile documentation #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Clarify support for multiple worker processes in Procfile documentation #8

wants to merge 2 commits into from

Conversation

louisabraham
Copy link

This PR addresses the ambiguity mentioned in piku/piku#404 regarding support for multiple worker processes in Procfile.

Changes Made

  • Clarified multiple worker support: Updated the worker section to explicitly state that multiple worker processes are supported with unique names
  • Added concrete examples: Provided clear examples showing multiple workers with different names (worker-host, worker-proxy, data-processor)
  • Explained naming constraints: Made it clear that worker names must not conflict with reserved worker types (wsgi, web, php, static, cron, preflight, release)
  • Highlighted benefits: Mentioned the advantage of being able to filter logs per worker using commands like piku logs worker-host
  • Updated initial example: Added a third worker example to show the pattern more clearly

Problem Solved

The original documentation was ambiguous about whether multiple workers were supported. Users could be confused about:

  1. Whether they can define multiple worker processes
  2. How to name them properly
  3. What the benefits are

This PR makes the documentation crystal clear on all these points, matching the actual behavior of the code which does support multiple workers with arbitrary names.

Fixes piku/piku#404

@louisabraham
Clarify support for multiple worker processes in Procfile
4caa645 
- Add clear explanation that multiple worker processes are supported
- Provide concrete example showing different worker names
- Explain that workers can have arbitrary names as long as they don't conflict with reserved types
- Mention the benefit of filtering logs per worker process

Fixes piku/piku#404
@louisabraham
clarify
229b9fa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support for multiple workers is not clear
1 participant
@louisabraham