Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix published value for objects loaded from version created before pi… #17086

Open
wants to merge 3 commits into
base: 11.4
Choose a base branch
from

Conversation

mhgtlc
Copy link
Contributor

@mhgtlc mhgtlc commented May 24, 2024

Changes in this pull request

Resolves #17085

Additional info

Copy link

Review Checklist

  • Target branch (11.2 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

Copy link

sonarcloud bot commented May 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@herbertroth herbertroth changed the base branch from 11.2 to 11.3 July 2, 2024 12:24
models/DataObject/Concrete.php Outdated Show resolved Hide resolved
@brusch brusch self-assigned this Jul 12, 2024
@kingjia90 kingjia90 changed the base branch from 11.3 to 11.4 October 1, 2024 08:56
@brusch
Copy link
Member

brusch commented Oct 31, 2024

I think it's fine if we go for the generic way that covers all the other o_ prefixed properties as well, as there's no difference between e.g. o_published and o_index.

Copy link

sonarcloud bot commented Oct 31, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants