Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add translation to the field title for csv and xlsx export #17353

Open
wants to merge 7 commits into
base: 11.x
Choose a base branch
from
Open

Add translation to the field title for csv and xlsx export #17353

wants to merge 7 commits into from

Conversation

kevinloeber-twocream
Copy link
Contributor

@kevinloeber-twocream kevinloeber-twocream commented Jul 15, 2024 •
edited
Loading

Changes in this pull request

Added that when exporting csv or xlsx files, the translation of the column names is specified and not the normal name

Additional info

So that the CSV and XLSX export in the GridView displays the names of the fields as column names. There is an adjustment to the input mask of the exports with a checkbox whether you want to use the field titles. There is also an adjustment to the export process to translate the field titles.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 15, 2024 •
edited by mattamon
Loading

Review Checklist

  • Target branch (11.2 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@CLAassistant
Copy link

CLAassistant commented Jul 25, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@kingjia90

This comment has been minimized.

Sign in to view
@kevinloeber-twocream
Copy link
Contributor Author

recheck

@mattamon mattamon added this to the 11.4.0 milestone Aug 29, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mattamon
Copy link
Contributor

Hey @kevinloeber-twocream I tried to test it, but could not make it work.

How should the translation work in general? I tried it with label and also system key but it never got translated.

@kevinloeber-twocream
Copy link
Contributor Author

Hey @mattamon , I have added two text fields in my data model as an example, which have a translation key as a label. When I add the fields in the grid view, the translations are displayed in Pimcore, but when I export the grid view as csv, only the translation keys are displayed and not the translations.
Pimcore:
image
image
image
Export:
image

@mattamon
Copy link
Contributor

@kevinloeber-twocream hmm okay I switched to your branch and still does not get translated for me.

@mattamon mattamon self-assigned this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mattamon mattamon

Labels
Improvement Pimcore:Backlog Pimcore:ToDo
Projects
None yet
Milestone
11.4.0
Development

Successfully merging this pull request may close these issues.
6 participants
@kevinloeber-twocream @CLAassistant @kingjia90 @mattamon @fashxp @wisconaut