added stage-type badges to teletraan environments page #1707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhnord
commented
Sep 3, 2024
| @@ -372,6 +372,9 @@ <h4 class="panel-title pull-left pointer-cursor"> | |||
| </div> | |||
| {% endif %} | |||
| {% endif %} | |||
| <h6 class="stage-type-badge"> | |||
| {{env.stageType|default:"NO STAGE TYPE"}} | |||
There was a problem hiding this comment.
added NO STAGE TYPE as stageType is an optional field from the API according to the docs
There was a problem hiding this comment.
I'm thinking we could show a warning if the stage type is missing, to encourage users to set it. The warning could be similar to the one in the screenshot.
However, I think we could discuss this separately, so this change looks good to me 👍
osoriano
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
canary:
control:
dev:
latest:
production:
staging: