Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --force option to spo site appcatalog remove command #6091

Closed
milanholemans opened this issue Jun 12, 2024 · 6 comments
Closed

Add --force option to spo site appcatalog remove command #6091

milanholemans opened this issue Jun 12, 2024 · 6 comments
Assignees
@Saurabh7019
Labels
breaking change enhancement work in progress
Milestone
v10

Comments

@milanholemans
Copy link
Contributor

Noticed that the command spo site appcatalog remove doesn't have a force parameter. Destructive commands should ask for confirmation.

Let's add option:

Option Description
-f, --force Don't prompt for confirmation
@milanholemans milanholemans added this to the v8 milestone Jun 12, 2024
@Adam-it
Copy link
Contributor

Adam-it commented Jun 16, 2024

TBH since this is a typical thing we have I wonder if we shouldn't consider this as bug and resolve this before v8.
@pnp/cli-for-microsoft-365-maintainers what you think?

@MathijsVerbeeck
Copy link
Contributor

TBH since this is a typical thing we have I wonder if we shouldn't consider this as bug and resolve this before v8. @pnp/cli-for-microsoft-365-maintainers what you think?

Scripts that currently are using this command will break, so it is a breaking change imo.

@milanholemans
Copy link
Contributor Author

milanholemans commented Jun 16, 2024 •
edited
Loading

Scripts that currently are using this command will break, so it is a breaking change imo.

That is exactly what I was thinking. Existing scripts will fail if we don't treat this as a breaking change. You can use this command just fine as it's documented right now.

We have another example in our v5.0.0 release: https://pnp.github.io/cli-microsoft365/v5-upgrade-guidance#extended-entra-oauth2grant-remove-with-confirm

@Adam-it
Copy link
Contributor

Adam-it commented Jul 7, 2024

Since we have v8 branch we may now start working on it!
Let's get this 🚢
and Let's put CLI to the 🚀🌙

@Saurabh7019
Copy link
Contributor

Can I work on it?

Saurabh7019 added a commit to Saurabh7019/cli-microsoft365 that referenced this issue Jul 10, 2024
@Saurabh7019
Add --force option to spo site appcatalog remove command. Closes pnp#…
400fa2c 
…6091
@Saurabh7019 Saurabh7019 mentioned this issue Jul 10, 2024
Closed
Saurabh7019 added a commit to Saurabh7019/cli-microsoft365 that referenced this issue Aug 1, 2024
@Saurabh7019
Add --force option to spo site appcatalog remove command. Closes pnp#…
b821060 
…6091
Saurabh7019 added a commit to Saurabh7019/cli-microsoft365 that referenced this issue Aug 5, 2024
@Saurabh7019
Add --force option to spo site appcatalog remove command. Closes pnp#…
be441c9 
…6091
Adam-it pushed a commit that referenced this issue Aug 11, 2024
@Saurabh7019 @Adam-it
Adds --force option to 'spo site appcatalog remove' command. Closes #…
3b4162d 
…6091
@Adam-it
Copy link
Contributor

Adam-it commented Aug 11, 2024

merged to v9

@Adam-it Adam-it closed this as completed Aug 11, 2024
MathijsVerbeeck pushed a commit that referenced this issue Aug 14, 2024
@Saurabh7019 @MathijsVerbeeck
Adds --force option to 'spo site appcatalog remove' command. Closes #…
61db913 
…6091
martinlingstuyl pushed a commit that referenced this issue Aug 14, 2024
@Saurabh7019 @martinlingstuyl
Adds --force option to 'spo site appcatalog remove' command. Closes #…
9c80eaf 
…6091
waldekmastykarz pushed a commit that referenced this issue Aug 17, 2024
@Saurabh7019 @waldekmastykarz
Adds --force option to 'spo site appcatalog remove' command. Closes #…
563e964 
…6091
milanholemans pushed a commit that referenced this issue Aug 17, 2024
@Saurabh7019 @milanholemans
Adds --force option to 'spo site appcatalog remove' command. Closes #…
7e1b68f 
…6091
milanholemans pushed a commit that referenced this issue Aug 24, 2024
@Saurabh7019 @milanholemans
Adds --force option to 'spo site appcatalog remove' command. Closes #…
da92b72 
…6091
Adam-it pushed a commit that referenced this issue Aug 29, 2024
@Saurabh7019 @Adam-it
Adds --force option to 'spo site appcatalog remove' command. Closes #…
a56c4cd 
…6091
milanholemans pushed a commit to milanholemans/cli-microsoft365 that referenced this issue Sep 1, 2024
@Saurabh7019 @milanholemans
Adds --force option to 'spo site appcatalog remove' command. Closes p…
1c6e1d0 
…np#6091
milanholemans pushed a commit that referenced this issue Sep 1, 2024
@Saurabh7019 @milanholemans
Adds --force option to 'spo site appcatalog remove' command. Closes #…
cb17da9 
…6091
milanholemans pushed a commit that referenced this issue Sep 5, 2024
@Saurabh7019 @milanholemans
Adds --force option to 'spo site appcatalog remove' command. Closes #…
0ea1a50 
…6091
MathijsVerbeeck pushed a commit that referenced this issue Sep 11, 2024
@Saurabh7019 @MathijsVerbeeck
Adds --force option to 'spo site appcatalog remove' command. Closes #…
cf3d43a 
…6091
waldekmastykarz pushed a commit that referenced this issue Sep 15, 2024
@Saurabh7019 @waldekmastykarz
Adds --force option to 'spo site appcatalog remove' command. Closes #…
6cb65a2 
…6091
Adam-it pushed a commit that referenced this issue Sep 18, 2024
@Saurabh7019 @Adam-it
Adds --force option to 'spo site appcatalog remove' command. Closes #…
e4ce2bd 
…6091
martinlingstuyl pushed a commit that referenced this issue Sep 20, 2024
@Saurabh7019 @martinlingstuyl
Adds --force option to 'spo site appcatalog remove' command. Closes #…
72695c0 
…6091
milanholemans pushed a commit that referenced this issue Sep 21, 2024
@Saurabh7019 @milanholemans
Adds --force option to 'spo site appcatalog remove' command. Closes #…
9dbdafc 
…6091
MathijsVerbeeck pushed a commit that referenced this issue Sep 24, 2024
@Saurabh7019 @MathijsVerbeeck
Adds --force option to 'spo site appcatalog remove' command. Closes #…
f1b35b3 
…6091
Adam-it pushed a commit that referenced this issue Sep 27, 2024
@Saurabh7019 @Adam-it
Adds --force option to 'spo site appcatalog remove' command. Closes #…
8c951c5 
…6091
ktskumar pushed a commit to ktskumar/cli-microsoft365 that referenced this issue Oct 8, 2024
@Saurabh7019 @ktskumar
Adds --force option to 'spo site appcatalog remove' command. Closes p…
90e0a07 
…np#6091
ktskumar pushed a commit to ktskumar/cli-microsoft365 that referenced this issue Oct 16, 2024
@Saurabh7019 @ktskumar
Adds --force option to 'spo site appcatalog remove' command. Closes p…
ba0f56e 
…np#6091
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Saurabh7019 Saurabh7019

Labels
breaking change enhancement work in progress
Projects
None yet
Milestone
v10
Development

No branches or pull requests
4 participants
@MathijsVerbeeck @milanholemans @Saurabh7019 @Adam-it