-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop vendoring CasePaths #87
Conversation
Package.swift
Outdated
@@ -16,10 +16,15 @@ let package = Package( | |||
targets: ["ComposableArchitecture"] | |||
), | |||
], | |||
dependencies: [ | |||
.package(url: "https://www.github.com/pointfreeco/swift-case-paths", from: "0.1.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this version good for pinning?
tolerance: SchedulerTimeType.Stride, | ||
options: SchedulerOptions?, | ||
tolerance _: SchedulerTimeType.Stride, | ||
options _: SchedulerOptions?, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unrelated but snuck this in. while working on some episode stuff I realized it's kinda nice to make it clear we aren't using this info
@@ -1,16 +0,0 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this file have been deleted? Wonder if it's needed for CI, but guess we'll find out!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
With our latest SPM-bug work around (#70) it seems we can now properly depend on the CasePaths library rather than venturing it directly.