Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ColumnFilter should be have hide option when click clear #10107

Closed
ffried opened this issue Apr 13, 2021 · 0 comments · Fixed by #10108
Closed

ColumnFilter should be have hide option when click clear #10107

ffried opened this issue Apr 13, 2021 · 0 comments · Fixed by #10108
Assignees
Labels
Type: New Feature Issue contains a new feature or new component request
Milestone

Comments

@ffried
Copy link
Contributor

ffried commented Apr 13, 2021

I'm submitting a ...

[ ] bug report => Search github for a similar issue or PR before submitting
[x] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)
none

Current behavior
When clicking the clear button in the menu overlay of a column filter, there's no way to automatically close the menu.

Expected behavior
There is an option to allow the menu to automatically close when the clear button is pressed.

Minimal reproduction of the problem with instructions
Create a filtered p-table (component demo with filter will suffice) and click the clear button.

What is the motivation / use case for changing the behavior?
I want to (optionally) close the menu when the clear button is clicked.

Please tell us about your environment:
macOS 11.2.3, WebStorm 2021.1

  • Angular version: 11.2

  • PrimeNG version: 11.2.3

  • Browser: all

  • Language: all

  • Node (for AoT issues): node --version = 15.14.0

@yigitfindikli yigitfindikli added the Type: New Feature Issue contains a new feature or new component request label Apr 13, 2021
@yigitfindikli yigitfindikli added this to the 11.4.0 milestone Apr 16, 2021
@yigitfindikli yigitfindikli self-assigned this Apr 16, 2021
@yigitfindikli yigitfindikli changed the title ColumnFilter should have an option to allow closing the menu on clear ColumnFilter, should be have hide option when click clear Apr 16, 2021
@yigitfindikli yigitfindikli changed the title ColumnFilter, should be have hide option when click clear ColumnFilter should be have hide option when click clear Apr 16, 2021
yigitfindikli added a commit that referenced this issue Apr 16, 2021
Fixed #10107 - ColumnFilter should be have hide option when click clear
yigitfindikli added a commit that referenced this issue Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: New Feature Issue contains a new feature or new component request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants