Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple ContextMenu's on the same page/component do not work as expected #11048

Closed
MarkStruik opened this issue Jan 10, 2022 · 1 comment
Closed
Assignees
Labels
LTS-PORTABLE Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@MarkStruik
Copy link

If you have a PrimeNG PRO Support subscription please post your issue at;

https://pro.primefaces.org

where our team will respond within 4 business hours.

If you do not have a PrimeNG PRO Support subscription, fill-in the report below. Please note that
your issue will be added to the waiting list of community issues and will be reviewed on a first-come first-serve basis, as a result, the support team is unable to guarantee a specific schedule on when it will be reviewed. Thank you for your understanding.

Current Queue Time for Review
Without PRO Support: ~8-12 weeks.
With PRO Support: 1 hour

I'm submitting a ... (check one with "x")

[x ] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)
Please demonstrate your case at stackblitz by using the issue template below. Issues without a test case have much less possibility to be reviewd in detail and assisted.

https://stackblitz.com/github/primefaces/primeng-issue-template

Current behavior
image
https://stackblitz.com/edit/primeng-tablecontextmenu-demo-b2qvhr

when we add two tables and two context menu's when right clicking on the tables in sequence they both open. But also synchronize the selection which is wrong!

Expected behavior
multiple contextMenu's should be supported

Minimal reproduction of the problem with instructions
reproduction with the sample from (https://www.primefaces.org/primeng/showcase/#/table/contextmenu) your site.
I just added an extra table and menu and made the context menu 'unique':

image

https://stackblitz.com/edit/primeng-tablecontextmenu-demo-b2qvhr

What is the motivation / use case for changing the behavior?
In my opinion this should just work. two separate contextMenu's should operate independently

Please tell us about your environment:
Angular 12, PrimeNG 12, Stackblitz ( but really anywhere you use the component )

  • Angular version: 5.X
    Angular 12

  • PrimeNG version: 5.X
    PrimeNG12

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
    All

  • Language: [all | TypeScript X.X | ES6/7 | ES5]
    Typescript 4.0.2

  • Node (for AoT issues): node --version =

package.json:
"dependencies": {
"rxjs": "6.6.7",
"quill": "1.3.7",
"tslib": "2.3.1",
"primeng": "13.0.4",
"zone.js": "0.11.4",
"chart.js": "3.7.0",
"primeflex": "2.0.0",
"primeicons": "5.0.0",
"@types/node": "8.9.5",
"@angular/cdk": "13.0.4",
"@angular/core": "13.0.3",
"@angular/forms": "13.0.3",
"@types/jasmine": "3.3.16",
"@angular/common": "13.0.3",
"@angular/router": "13.0.3",
"@angular/compiler": "13.0.3",
"@types/jasminewd2": "2.0.8",
"web-animations-js": "2.3.2",
"@fullcalendar/core": "4.4.0",
"@angular/animations": "13.0.3",
"@angular/platform-browser": "13.0.3",
"@angular/platform-browser-dynamic": "13.0.3"
},
"scripts": {
"ng": "ng",
"start": "ng serve",
"build": "ng build",
"test": "ng test",
"lint": "ng lint",
"e2e": "ng e2e"
},
"devDependencies": {
"@angular-devkit/build-angular": "~0.1100.4",
"@angular/cli": "~11.0.4",
"@angular/compiler-cli": "~11.0.4",
"@types/jasmine": "~3.6.0",
"@types/node": "^12.11.1",
"codelyzer": "^6.0.0",
"jasmine-core": "~3.6.0",
"jasmine-spec-reporter": "~5.0.0",
"karma": "~5.1.0",
"karma-chrome-launcher": "~3.1.0",
"karma-coverage": "~2.0.3",
"karma-jasmine": "~4.0.0",
"karma-jasmine-html-reporter": "^1.5.0",
"protractor": "~7.0.0",
"ts-node": "~8.3.0",
"tslint": "~6.1.0",
"typescript": "~4.0.2"
}

@yigitfindikli yigitfindikli added this to the 13.0.5 milestone Jan 12, 2022
@yigitfindikli yigitfindikli added Status: Pending Review Issue or pull request is being reviewed by Core Team Type: Bug Issue contains a bug related to a specific component. Something about the component is not working LTS-PORTABLE and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Jan 12, 2022
@MarkStruik
Copy link
Author

So this is closed without any update? Is this fixed? Is there a change in api i need to be aware of ? any comments would be very beneficial

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LTS-PORTABLE Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

3 participants