Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar view="month" and selectionMode="range" not working properly #11153

Closed
tania77 opened this issue Feb 8, 2022 · 7 comments
Closed

Calendar view="month" and selectionMode="range" not working properly #11153

tania77 opened this issue Feb 8, 2022 · 7 comments
Assignees
Milestone

Comments

@tania77
Copy link

tania77 commented Feb 8, 2022

I'm submitting a ... (check one with "x")

[X] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)
https://stackblitz.com/edit/primeng-calendar-demo-nrnhmx?file=src%2Fapp%2Fapp.component.ts

Current behavior
Currently if you set the calendar component with view="month" and selectionMode="range" the selected range is not been highlighted.
Also, if you set up the property maxDate, the corresponding dates (in this case months) are not being disabled.

Expected behavior
The selected month range should be highlighted.
Months after maxDate should be disabled.

Minimal reproduction of the problem with instructions
Using the example provided, select a range of months.
Notice that even with maxDate set to February, months after that are not being disabled

What is the motivation / use case for changing the behavior?
The user needs to see the range he/she selected
I need to be able to show the user that future dates (months) are not avaible to select

Please tell us about your environment:

  • Angular version: 5.X
  • PrimeNG version: 5.X
  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
    Operating system: Windows 10 Enterprise
    IDE: VSCode
    Package manager: npm, node

Angular version:
13.2.1

PrimeNG version:
13.1.0

Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
Chrome 89.0.4389.128

Language: [all | TypeScript X.X | ES6/7 | ES5]
TypeScript 4.1.2

Node (for AoT issues): node --version =
v14.15.1

@yigitfindikli yigitfindikli added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Feb 9, 2022
@yigitfindikli yigitfindikli added this to the 13.Future milestone Feb 9, 2022
@antialiasis
Copy link

Also bumped into this problem today.

@MatheusWebDev
Copy link

I'm also going through the same situation.

@jacobmhulse
Copy link

This is a pretty critical UX issue, can we get an idea on when this bug will be resolved?

Appreciate the amazing work!!!

@jacobmhulse
Copy link

Issue also impacts year view with range selection.

@sbarlabanov
Copy link
Contributor

We also encountered the same issue after having upgraded to Angular 13 and PrimeNG 13. Seems that there is the same problem with years range selection with the corresponding PR: #11426.

@sbarlabanov
Copy link
Contributor

sbarlabanov commented Jun 26, 2022

Here is the fix pr for the month range selection problem: #11655

@mcrtricolor
Copy link

I think is related, but if you choose year and month navigation, the dates outside the min and max dates are available to select. They should be disabled.

@cetincakiroglu cetincakiroglu modified the milestones: 14.Future, 14.1.2 Sep 26, 2022
@cetincakiroglu cetincakiroglu removed the Status: Pending Review Issue or pull request is being reviewed by Core Team label Sep 26, 2022
cetincakiroglu added a commit that referenced this issue Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants