Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

p-calendar in range mode does not allow manually typing in same start and end date #12286

Closed
robuandrei opened this issue Nov 28, 2022 · 3 comments · Fixed by #14781
Closed

p-calendar in range mode does not allow manually typing in same start and end date #12286

robuandrei opened this issue Nov 28, 2022 · 3 comments · Fixed by #14781
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
17.13.0

Comments

@robuandrei
Copy link

Describe the bug

Using p-calendar in range mode. Need to be able to type in a date range with the same start and end date. This can be selected from the UI picker by clicking the same day twice. However, if a date range of the same day is typed in manually then the input is rejected and the calendar reverts to its previous selection.

Environment

OS: Windows 11
Browser: Google Chrome
Can be reproduced in stackblitz in the library documentation example, so all other environment information should be accessible there.

Reproducer

https://stackblitz.com/edit/primeng-calendar-demo-kj1zcc

Angular version

14.2.8

PrimeNG version

14.1.2

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.11.7

Browser(s)

Chrome 121

Steps to reproduce the behavior

When the user enters a date range with the same start and end date and after that clicks outside of the p-calendar input, the entered value is rejected.

Expected behavior

Since a date range with the same start and end date is valid from the UI picker, it should also be valid when typed in manually not only when the range is selected from the picker.
@robuandrei robuandrei added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 28, 2022
@Yuliasik
Copy link

The same issue reproduced on ^12.0.1 version of PrimeNG

@sandrotonon
Copy link
Contributor

Still not working with version 17.3.2

@sandrotonon sandrotonon mentioned this issue Jan 19, 2024
Closed
eduardheller89 pushed a commit to eduardheller89/primeng that referenced this issue Feb 10, 2024
@eduardeviden
Fix primefaces#14590 and primefaces#12286 - Single dates only calende…
8f60d0d 
…r not possible with hand typing
@eduardheller89 eduardheller89 mentioned this issue Feb 10, 2024
Merged
@cetincakiroglu cetincakiroglu added this to the 17.13.0 milestone Mar 22, 2024
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Mar 22, 2024
cetincakiroglu added a commit that referenced this issue Mar 22, 2024
@cetincakiroglu
Merge pull request #14781 from eduardheller89/master
57d2950 
Fix #14590 and #12286 - Single dates not possible with calendar in range mode
@PitamahBhishma-0
Copy link

hey is this solved ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
17.13.0
Development

Successfully merging a pull request may close this issue.

Fix #14590 and #12286 - Single dates not possible with calendar in range mode eduardheller89/primeng
5 participants
@sandrotonon @robuandrei @PitamahBhishma-0 @cetincakiroglu @Yuliasik