Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog: Missing Aria Label on Maximize button #14949

Closed
WTW-Steve-Martin opened this issue Mar 5, 2024 · 1 comment · Fixed by #15156
Closed

Dialog: Missing Aria Label on Maximize button #14949

WTW-Steve-Martin opened this issue Mar 5, 2024 · 1 comment · Fixed by #15156
Assignees
@mehmetcetin01140
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA PRO Support Issue was reported by PRO User
Milestone
17.13.0

Comments

@WTW-Steve-Martin
Copy link

Describe the bug

The Axe Dev Tools for Accessibility is reporting the following issue:
image

Axe is highlighting that the Maximize button doesn't have an Aria Label

Environment

Windows 10

Reproducer

No response

Angular version

17.2.3

PrimeNG version

17.9.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.18.0

Browser(s)

No response

Steps to reproduce the behavior

  1. Install the Axe Dev Tools for Accessibility plug-in.
  2. Visit the PrimeNG dialog page (https://primeng.org/dialog) on Chrome/Edge browser.
  3. Scan the page with Axe

Expected behavior

The Axe scan doesn't return this error.
@WTW-Steve-Martin WTW-Steve-Martin added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 5, 2024
@mehmetcetin01140 mehmetcetin01140 added Component: Accessibility Issue or pull request is related to WCAG or ARIA and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Mar 18, 2024
@WTW-Steve-Martin
Copy link
Author

Hi,
Has this issue been assigned a milestone please?

@cetincakiroglu cetincakiroglu added this to the 17.13.0 milestone Mar 22, 2024
@cetincakiroglu cetincakiroglu added the PRO Support Issue was reported by PRO User label Mar 25, 2024
mehmetcetin01140 added a commit that referenced this issue Mar 25, 2024
@mehmetcetin01140
Fixed #14949 - Dialog | Missing Aria Label on Maximize button
f8ee175
@mehmetcetin01140 mehmetcetin01140 mentioned this issue Mar 25, 2024
Merged
cetincakiroglu added a commit that referenced this issue Mar 26, 2024
@cetincakiroglu
Merge pull request #15156 from primefaces/issue-14949
d5ec062 
Fixed #14949 - Dialog | Missing Aria Label on Maximize button
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mehmetcetin01140 mehmetcetin01140

Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA PRO Support Issue was reported by PRO User
Projects
None yet
Milestone
17.13.0
Development

Successfully merging a pull request may close this issue.

Fixed #14949 - Dialog | Missing Aria Label on Maximize button primefaces/primeng
3 participants
@cetincakiroglu @mehmetcetin01140 @WTW-Steve-Martin