Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OrderList: Unable to insert space into input component #15326

Closed
spahicharis opened this issue Apr 21, 2024 · 1 comment · Fixed by #15809 · 4 remaining pull requests
Closed

OrderList: Unable to insert space into input component #15326

spahicharis opened this issue Apr 21, 2024 · 1 comment · Fixed by #15809 · 4 remaining pull requests
Assignees
@mehmetcetin01140
Labels
LTS-16-PORTABLE LTS-FIXED-16.9.11 Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
17.18.1

Comments

@spahicharis
Copy link

Describe the bug

While using input element inside p-orderList component one is not able to insert space into it. Here is the screenshot example:

image

image

Environment

Issue is easily reproducible on latest primeng version 17.14.1.

Reproducer

No response

Angular version

17.0.8

PrimeNG version

17.14.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.16.1

Browser(s)

No response

Steps to reproduce the behavior

Prerequisites
Have installed Angular app and setup primeng components
Import p-orderList component

Steps to reproduce

  1. Edit p-orderList template (pTemplate="item")
  2. Put basic input field in pTemplate
  3. Run app using command ng serve
  4. Try to put space into input field

Expected behavior

I should be able to insert space into input.
@spahicharis spahicharis added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 21, 2024
@mjlux
Copy link

mjlux commented May 5, 2024

The default behaviour of a OrderListItem on space is to select/unselect the item.
We faced the same issue and resolved it by adding an (keydown.space)="$event.stopPropagation()" EventListener to the input.
Hope this helps.

@mehmetcetin01140 mehmetcetin01140 added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jun 6, 2024
@mehmetcetin01140 mehmetcetin01140 added this to the 17.18.1 milestone Jun 6, 2024
@mehmetcetin01140 mehmetcetin01140 self-assigned this Jun 7, 2024
mehmetcetin01140 added a commit that referenced this issue Jun 7, 2024
@mehmetcetin01140
Fixed #15326 - OrderList: Unable to insert space into input component
6c060f7
@mehmetcetin01140 mehmetcetin01140 mentioned this issue Jun 7, 2024
Merged
cetincakiroglu added a commit that referenced this issue Jun 13, 2024
@cetincakiroglu
Merge pull request #15809 from primefaces/issue-15326
8088fb9 
Fixed #15326 - OrderList: Unable to insert space into input component
This was referenced Jul 18, 2024
Open
Open
@diaz-rigo diaz-rigo mentioned this issue Jul 21, 2024
Open
@Rodolphe33 Rodolphe33 mentioned this issue Jul 26, 2024
Open
@Rodolphe33 Rodolphe33 mentioned this issue Aug 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mehmetcetin01140 mehmetcetin01140

Labels
LTS-16-PORTABLE LTS-FIXED-16.9.11 Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
17.18.1
3 participants
@spahicharis @mjlux @mehmetcetin01140