Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add input number attribute transform fns #14646

Merged
merged 3 commits into from
Apr 1, 2024
Merged

Feature/add input number attribute transform fns #14646

merged 3 commits into from
Apr 1, 2024

Conversation

LcsGa
Copy link
Contributor

@LcsGa LcsGa commented Jan 28, 2024

This PR as the same background as this one

@vercel Vercel
Copy link

vercel bot commented Jan 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Mar 29, 2024 5:10pm

@cetincakiroglu cetincakiroglu added Status: Pending Review Issue or pull request is being reviewed by Core Team Status: Discussion Issue or pull request needs to be discussed by Core Team labels Mar 22, 2024
@cetincakiroglu
Copy link
Contributor

cetincakiroglu commented Mar 22, 2024 •
edited
Loading

Hi,

Huge thanks for the effort and support, great PR!
Could you please resolve the conflicts so we can merge safely?
Also, I see that you have another PR #14645 which one should we focused on? It seems two of them nearly identical but this one has more changed files. If both of them valid, could you please send them into 1 PR?

@cetincakiroglu cetincakiroglu added Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. and removed Status: Pending Review Issue or pull request is being reviewed by Core Team Status: Discussion Issue or pull request needs to be discussed by Core Team labels Mar 22, 2024
@LcsGa
Copy link
Contributor Author

LcsGa commented Mar 22, 2024

Hi! Yes I can resolve the conflicts in 2-3 days and about the 2 PRs, I created this one based on the first one as I thought I could merge this one into thé other and the other one into master 😅
So the other one can be deleted

@cetincakiroglu
Copy link
Contributor

@LcsGa ,

Thanks a lot, please tag me after you are done with the changes.

@LcsGa
Copy link
Contributor Author

LcsGa commented Mar 29, 2024

Hey @cetincakiroglu,
It should be alright now 😉 !

Sorry for the delay, I had less time than I thought 😅

@cetincakiroglu cetincakiroglu merged commit 48c8519 into primefaces:master Apr 1, 2024
2 checks passed
@cetincakiroglu cetincakiroglu mentioned this pull request Apr 1, 2024
Closed
@LcsGa LcsGa deleted the feature/add-input-number-attribute-transform-fns branch April 2, 2024 00:36
@BGBRWR BGBRWR mentioned this pull request Apr 9, 2024
Merged
@dobanisola-scottlogic dobanisola-scottlogic mentioned this pull request Apr 22, 2024
Closed
@heiooyooy heiooyooy mentioned this pull request May 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cetincakiroglu cetincakiroglu cetincakiroglu approved these changes

Assignees
No one assigned
Labels
Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LcsGa @cetincakiroglu