Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a boolean which indicates if the drop is in a drop point or a node #16174

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Eiael
Copy link

@Eiael Eiael commented Aug 6, 2024

Fixed #16170 : We can now implement different behavior based on drop element type

Copy link

vercel bot commented Aug 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Sep 20, 2024 7:33am
primeng-v18 ⬜️ Ignored (Inspect) Visit Preview Sep 20, 2024 7:33am

@cetincakiroglu cetincakiroglu added good first issue *** Welcome to PrimeNG Family! *** Good issue! Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add Type: New Feature Issue contains a new feature or new component request labels Aug 8, 2024
/**
* Indicates if the node is dropped in a drop point between nodes
*/
dropPoint?: boolean;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Eiael How about using a literate string type, example: type DropPoint = 'node' | 'between'

dropPoint: DropPoint

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds better, fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue *** Welcome to PrimeNG Family! *** Good issue! Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add Type: New Feature Issue contains a new feature or new component request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[p-tree] Distinguish between a drop on the nodes and a drop between the nodes
3 participants