Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #16225 multiselect-items-wrapper a11y issue #16226

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TaneliTuomola
Copy link

fixes #16225 #15003

Copy link

vercel bot commented Aug 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Aug 14, 2024 10:43am

@cetincakiroglu
Copy link
Contributor

Hi,

Thanks for the PR. This implementation breaks the current tabbing behavior of multiselect component. Could you please make it behave the same as in the dropdown? We have the same implementation in the dropdown component.

@cetincakiroglu cetincakiroglu added the Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. label Aug 15, 2024
@TaneliTuomola
Copy link
Author

TaneliTuomola commented Aug 16, 2024

Hi,

Thanks for the PR. This implementation breaks the current tabbing behavior of multiselect component. Could you please make it behave the same as in the dropdown? We have the same implementation in the dropdown component.

I was unable to reproduce any of the keyboard usage issues. The component works the same as before the change. @cetincakiroglu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiselect: Scrollable region must have keyboard access
2 participants