Fix #15192: Row grouping breaks after first page #16307
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15192
What was the problem
shouldRenderRowGroupHeader
expects therowIndex
to be the absolute index (i.e.first + rowIndex
) when paginated.The problem was that the
rowIndex
passed starts from0
for every page, and the index calculation in the method then resulted in a negative number.How was the problem solved
For expanded rows, the method
getRowIndex
is used, which adds the starting offset (first
) to therowIndex
.This method is used here now as well.