-
Notifications
You must be signed in to change notification settings - Fork 9.8k
prepare release 3.7-rc.0 #17274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prepare release 3.7-rc.0 #17274
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! I've made some styling comments
/prombench v3.6.0 |
⏱️ Welcome to Prometheus Benchmarking Tool. ⏱️ Compared versions: After the successful deployment (check status here), the benchmarking results can be viewed at: Available Commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
I haven’t gone through the whole changelog yet, I will continue when I have time (we still need to wait for the prombench anyway).
/prombench cancel |
Benchmark cancel is in progress. |
/prombench restart v3.6.0 |
⏱️ Welcome (again) to Prometheus Benchmarking Tool. ⏱️ Compared versions: After successful deployment (check status here), the benchmarking results can be viewed at: Available Commands:
|
/prombench cancel |
Benchmark cancel is in progress. |
/prombench v3.6.0 |
⏱️ Welcome to Prometheus Benchmarking Tool. ⏱️ Compared versions: After the successful deployment (check status here), the benchmarking results can be viewed at: Available Commands:
|
/prombench cancel |
Benchmark cancel is in progress. |
006f904
to
4bb2f9e
Compare
/prombench v3.6.0 |
⏱️ Welcome to Prometheus Benchmarking Tool. ⏱️ Compared versions: After the successful deployment (check status here), the benchmarking results can be viewed at: Available Commands:
|
/prombench cancel |
Benchmark cancel is in progress. |
4bb2f9e
to
8502f3c
Compare
/prombench v3.6.0 |
⏱️ Welcome to Prometheus Benchmarking Tool. ⏱️ Compared versions: After the successful deployment (check status here), the benchmarking results can be viewed at: Available Commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thanks, can we merge and release? 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some final suggestions.
Thanks again!
* [BUGFIX] PromQL: Fix character position computed for end of aggregate expression. #16996 #17031 | ||
* [BUGFIX] PromQL: Fix info function on churning series. #17135 | ||
* [BUGFIX] PromQL: Set native histogram to gauge type when subtracting or multiplying/dividing with negative factors. #17004 | ||
* [BUGFIX] TSDB: Reject unsupported native histogram schemas when attempting to append to TSDB. For scrape and remote-write implement reducing the resolution to fit the maximum if the schema is within the -9 to 52. #17189 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* [BUGFIX] TSDB: Reject unsupported native histogram schemas when attempting to append to TSDB. For scrape and remote-write implement reducing the resolution to fit the maximum if the schema is within the -9 to 52. #17189 | |
* [BUGFIX] TSDB: Reject unsupported Native Histogram schemas when attempting to append to TSDB. #17189 |
(Prometheus binary users don't need to know about the details)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think they do need to know about it. Resolution is very apparent in heatmaps especially.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okk, you're the expert :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
16737 was in 3.6. 16923 lacked number and a bit underdefined. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Bump versions and changelog. Co-authored-by: Arthur Silva Sens <arthursens2005@gmail.com> Co-authored-by: Ayoub Mrini <ayoubmrini424@gmail.com> Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
9d69898
to
736ad1f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits
* [ENHANCEMENT] UI: Add scrape interval and scrape timeout to targets page. #17158 | ||
* [ENHANCEMENT] TSDB: Reduce the resolution of native histograms read from chunks or remote read if the schema is exponential. #17213 | ||
* [ENHANCEMENT] Remote write: Add logging for unexpected metadata in sample batches, when metadata entries are found in samples-only batches. #17034 #17082 | ||
* [ENHANCEMENT] Remote-write: Add `prometheus_remote_storage_queue_highest_timestamp_seconds` metric, tracking the highest timestamp actually enqueued, taking `write_relabel_configs` into account. #17065 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth having this on two lines - a CHANGE and an ENHANCEMENT?
* [PERF] PromQL: Move more work to preprocessing step. #16896 | ||
* [PERF] PromQL: Reduce allocations when walking the syntax tree. #16593 | ||
* [PERF] TSDB: Optimize appender creation, slightly speeding up startup. #16922 | ||
* [PERF] TSDB: Improve reverse index lookup performance. #13971 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do Prometheus admins know what "reverse index" means?
Since the change is focused on intersections, suggest something like "Improve speed of querying a series with multiple matchers".
* [BUGFIX] Config: Infer valid escaping scheme when scrape config validation scheme is set. #16923 | ||
* [BUGFIX] TSDB: Correctly handle appending mixed-typed samples to the same series. #17071 #17241 #17290 #17295 #17296 | ||
* [BUGFIX] Remote-write: Prevent sending unsupported native histograms with custom buckets (NHCB) over Remote-write 1.0, log warning. #17146 | ||
* [BUGFIX] TSDB: Fix metadata entries handling on `metadata-wal-records` feature for Native Histograms with custom buckets in protobuf scraping. #17156 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest "experimental feature"
As per release process.